[libc][ctime] move null pointer check before dereference

szsam · mysterywolf · commit c7ad493b9ac3 · 2023-06-13T18:29:22.000-04:00
This null check was redundant because the pointer timep was
dereferenced in any case.
diff --git a/components/libc/compilers/common/ctime.c b/components/libc/compilers/common/ctime.c
@@ -177,7 +177,7 @@ static int set_timeval(struct timeval *tv)
 struct tm *gmtime_r(const time_t *timep, struct tm *r)
 {
     int i;
-    int work = *timep % (SPD);
+    int work;
 
     if(timep == RT_NULL || r == RT_NULL)
     {
@@ -187,6 +187,7 @@ struct tm *gmtime_r(const time_t *timep, struct tm *r)
 
     rt_memset(r, RT_NULL, sizeof(struct tm));
 
+    work = *timep % (SPD);
     r->tm_sec = work % 60;
     work /= 60;
     r->tm_min = work % 60;

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ static int set_timeval(struct timeval *tv)`
`177`	`177`	`struct tm gmtime_r(const time_t timep, struct tm *r)`
`178`	`178`	`{`
`179`	`179`	`int i;`
`180`		`- int work = *timep % (SPD);`
	`180`	`+ int work;`
`181`	`181`
`182`	`182`	`if(timep == RT_NULL \|\| r == RT_NULL)`
`183`	`183`	`{`
`@@ -187,6 +187,7 @@ struct tm gmtime_r(const time_t timep, struct tm *r)`
`187`	`187`
`188`	`188`	`rt_memset(r, RT_NULL, sizeof(struct tm));`
`189`	`189`
	`190`	`+ work = *timep % (SPD);`
`190`	`191`	`r->tm_sec = work % 60;`
`191`	`192`	`work /= 60;`
`192`	`193`	`r->tm_min = work % 60;`