You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The content in this square bracket must be filled in and replaced, otherwise PR can not be merged. The contents outside square brackets need not be changed, but please read them carefully.
5
+
6
+
Please fill in your PR description here, which can include one of the following items: why to submit this PR; what is the problem solved and what is your solution;
7
+
8
+
And confirm in which case or board have been tested.
9
+
]
10
+
11
+
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
12
+
13
+
### Intent for your PR
14
+
15
+
Choose one (Mandatory):
16
+
17
+
-[ ] This PR is for a code-review and is intended to get feedback
18
+
-[ ] This PR is mature, and ready to be integrated into the repo
19
+
20
+
### Code Quality:
21
+
22
+
As part of this pull request, I've considered the following:
23
+
24
+
-[ ] Already check the difference between PR and old code
25
+
-[ ] Style guide is adhered to, including spacing, naming and other style
26
+
-[ ] All redundant code is removed and cleaned up
27
+
-[ ] BSP All modifications are justified and not affect other components or BSP
28
+
-[ ] I've commented appropriately where code is tricky
The content in this square bracket must be filled in and replaced, otherwise, PR can not be merged. The contents outside square brackets need not be changed, but please read them carefully.
Please fill in your PR description here, which can include one of the following items: why to submit this PR; what is the problem solved and what is your solution;
9
+
10
+
并确认并列出已经在什么情况或板卡上进行了测试。
11
+
And confirm in which case or board has been tested.
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
16
+
17
+
### 当前拉取/合并请求的状态 Intent for your PR
18
+
19
+
必须选择一项 Choose one (Mandatory):
20
+
21
+
-[ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
22
+
-[ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo
23
+
24
+
### 代码质量 Code Quality:
25
+
26
+
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
27
+
28
+
-[ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
29
+
-[ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
30
+
-[ ] 没有垃圾代码,代码尽量精简,不包含`#if 0`代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
31
+
-[ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
32
+
-[ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
33
+
-[ ] 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
0 commit comments