Skip to content

Conversation

wycwyhwyq
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#10056

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    riscv/K230
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added RT-Smart RT-Thread Smart related PR or issues component: lwp Component labels Feb 28, 2025
@BernardXiong
Copy link
Member

请给出更多的测试用例,谢谢。

unicornx pushed a commit to unicornx/rt-thread that referenced this pull request Apr 2, 2025
We have a PR: RT-Thread#10057
submitted, but note it's a bit different against this patch.

For example:
- changes for lwp.c is not submitted.
- changes for ctime.c is a bit different.
unicornx pushed a commit to unicornx/rt-thread that referenced this pull request Apr 3, 2025
We have a PR: RT-Thread#10057
submitted, but note it's a bit different against this patch.

For example:
- changes for lwp.c is not submitted.
- changes for ctime.c is a bit different.
unicornx pushed a commit to unicornx/rt-thread that referenced this pull request Apr 3, 2025
We have a PR: RT-Thread#10057
submitted, but note it's a bit different against this patch.

For example:
- changes for lwp.c is not submitted.
- changes for ctime.c is a bit different.
unicornx pushed a commit to unicornx/rt-thread that referenced this pull request Apr 14, 2025
We have a PR: RT-Thread#10057
submitted, but note it's a bit different against this patch.

For example:
- changes for lwp.c is not submitted.
- changes for ctime.c is a bit different.

RT_ASSERT(data->tid);

/* stop others from delete thread */
thread = lwp_tid_get_thread_and_inc_ref(data->tid);
/** The tid of thread is a READ ONLY value, but here still facing the risk of thread already been delete error */
ret = lwp_thread_signal_kill(thread, data->signo, SI_TIMER, 0);
ext = rt_malloc(sizeof(struct lwp_siginfo_ext));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我有错过了什么吗?这里有对应的内存分配,后续没有释放的,会出现泄漏的情况?

@BernardXiong BernardXiong added the discussion This PR/issue needs to be discussed later label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: lwp Component discussion This PR/issue needs to be discussed later RT-Smart RT-Thread Smart related PR or issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants