Skip to content

Commit 98d4543

Browse files
committed
- Simplification of code
- Correction of documentation (in types of $filterInstances)
1 parent 87a3b21 commit 98d4543

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/AssetManager/Service/AssetFilterManager.php

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,8 @@ class AssetFilterManager implements ServiceLocatorAwareInterface, MimeResolverAw
2727
protected $mimeResolver;
2828

2929
/**
30-
*
31-
* @var Filters[] Filters already instanced
32-
*/
33-
30+
* @var FilterInterface[] Filters already instantiated
31+
*/
3432
protected $filterInstances = array();
3533

3634
/**
@@ -151,14 +149,13 @@ protected function ensureByFilter(AssetInterface $asset, $filter)
151149
'No filter found for ' . $filter
152150
);
153151
}
154-
155-
if (!array_key_exists($filterClass, $this->filterInstances)) {
156-
$filterInstance = new $filterClass;
157-
$this->filterInstances[$filterClass] = $filterInstance;
158-
} else {
159-
$filterInstance = $this->filterInstances[$filterClass];
152+
153+
if (!isset($this->filterInstances[$filterClass])) {
154+
$this->filterInstances[$filterClass] = new $filterClass();
160155
}
161156

157+
$filterInstance = $this->filterInstances[$filterClass];
158+
162159
$asset->ensureFilter($filterInstance);
163160
}
164161

0 commit comments

Comments
 (0)