Skip to content

Commit b848769

Browse files
committed
- Code improvements, PSR2 fix
1 parent 67608f3 commit b848769

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

tests/AssetManagerTest/Service/AssetManagerTest.php

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,23 @@ public function testSetExtensionFilters()
211211
$assetManager->setAssetOnResponse($response);
212212
$this->assertEquals($minified, $response->getBody());
213213
}
214+
public function getCollectionResolver()
215+
{
216+
$aggregateResolver = new AggregateResolver;
217+
$mockedResolver = $this->getResolver(__DIR__ . '/../../_files/require-jquery.js');
218+
$collArr = array(
219+
'blah.js' => array(
220+
'asset-path'
221+
)
222+
);
223+
$resolver = new CollectionResolver($collArr);
224+
$resolver->setAggregateResolver($aggregateResolver);
225+
226+
$aggregateResolver->attach($mockedResolver, 500);
227+
$aggregateResolver->attach($resolver, 1000);
228+
229+
return $resolver;
230+
}
214231
public function testSetExtensionFiltersNotDuplicate()
215232
{
216233
$config = array(
@@ -222,33 +239,20 @@ public function testSetExtensionFiltersNotDuplicate()
222239
),
223240
),
224241
);
225-
242+
243+
$resolver = $this->getCollectionResolver();
226244
$assetFilterManager = new AssetFilterManager($config['filters']);
227245
$mimeResolver = new MimeResolver;
228246
$assetFilterManager->setMimeResolver($mimeResolver);
229-
230-
$aggregateResolver = new AggregateResolver;
231-
$mockedResolver = $this->getResolver(__DIR__ . '/../../_files/require-jquery.js');
232-
$collArr = array(
233-
'blah.js' => array(
234-
'asset-path'
235-
)
236-
);
237-
$resolver = new CollectionResolver($collArr);
238247
$resolver->setAssetFilterManager($assetFilterManager);
239-
$resolver->setAggregateResolver($aggregateResolver);
240-
241-
$aggregateResolver->attach($mockedResolver, 500);
242-
$aggregateResolver->attach($resolver, 1000);
243-
244248

245249
$response = new Response;
246250
$request = $this->getRequest();
247251
// Have to change uri because asset-path would cause an infinite loop
248252
$request->setUri('http://localhost/base-path/blah.js');
249253

250254
$assetCacheManager = $this->getAssetCacheManagerMock();
251-
$assetManager = new AssetManager($aggregateResolver, $config);
255+
$assetManager = new AssetManager($resolver->getAggregateResolver(), $config);
252256
$assetManager->setAssetCacheManager($assetCacheManager);
253257
$assetManager->setAssetFilterManager($assetFilterManager);
254258

0 commit comments

Comments
 (0)