Merge pull request #115 from michaelmoussa/atomic-cache-file-writing

RWOverdijk · RWOverdijk · commit ef5965c763dd · 2013-12-05T14:17:38.000-08:00
Achieve atomic cache writes
diff --git a/src/AssetManager/Cache/FilePathCache.php b/src/AssetManager/Cache/FilePathCache.php
@@ -87,7 +87,10 @@ public function set($key, $value)
             throw new \RuntimeException('Unable to write file ' . $this->cachedFile());
         }
 
-        file_put_contents($this->cachedFile(), $value);
+        // Use "rename" to achieve atomic writes
+        $tmpFilePath = $cacheDir . '/' . uniqid('AssetManagerFilePathCache');
+        file_put_contents($tmpFilePath, $value);
+        rename($tmpFilePath, $this->cachedFile());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,10 @@ public function set($key, $value)`
`87`	`87`	`throw new \RuntimeException('Unable to write file ' . $this->cachedFile());`
`88`	`88`	`}`
`89`	`89`
`90`		`- file_put_contents($this->cachedFile(), $value);`
	`90`	`+ // Use "rename" to achieve atomic writes`
	`91`	`+ $tmpFilePath = $cacheDir . '/' . uniqid('AssetManagerFilePathCache');`
	`92`	`+ file_put_contents($tmpFilePath, $value);`
	`93`	`+ rename($tmpFilePath, $this->cachedFile());`
`91`	`94`	`}`
`92`	`95`
`93`	`96`	`/**`