Revert "[Utils] Add new --update-tests flag to llvm-lit" (#110772)

Reverts llvm/llvm-project#108425

Author: hnrklssn

lit/LitConfig.py

@@ -38,7 +38,6 @@ def __init__(
         parallelism_groups={},
         per_test_coverage=False,
         gtest_sharding=True,
-        update_tests=False,
     ):
         # The name of the test runner.
         self.progname = progname
@@ -90,8 +89,6 @@ def __init__(
         self.parallelism_groups = parallelism_groups
         self.per_test_coverage = per_test_coverage
         self.gtest_sharding = bool(gtest_sharding)
-        self.update_tests = update_tests
-        self.test_updaters = []
 
     @property
     def maxIndividualTestTime(self):

lit/TestRunner.py

@@ -1190,18 +1190,6 @@ def executeScriptInternal(
                 str(result.timeoutReached),
             )
 
-        if litConfig.update_tests:
-            for test_updater in litConfig.test_updaters:
-                try:
-                    update_output = test_updater(result, test)
-                except Exception as e:
-                    out += f"Exception occurred in test updater: {e}"
-                    continue
-                if update_output:
-                    for line in update_output.splitlines():
-                        out += f"# {line}\n"
-                    break
-
     return out, err, exitCode, timeoutInfo
 
 

lit/cl_arguments.py

@@ -204,12 +204,6 @@ def parse_args():
         action="store_true",
         help="Exit with status zero even if some tests fail",
     )
-    execution_group.add_argument(
-        "--update-tests",
-        dest="update_tests",
-        action="store_true",
-        help="Try to update regression tests to reflect current behavior, if possible",
-    )
     execution_test_time_group = execution_group.add_mutually_exclusive_group()
     execution_test_time_group.add_argument(
         "--skip-test-time-recording",

lit/llvm/config.py

@@ -64,17 +64,12 @@ def __init__(self, lit_config, config):
             self.with_environment("_TAG_REDIR_ERR", "TXT")
             self.with_environment("_CEE_RUNOPTS", "FILETAG(AUTOCVT,AUTOTAG) POSIX(ON)")
 
-        if lit_config.update_tests:
-            self.use_lit_shell = True
-
         # Choose between lit's internal shell pipeline runner and a real shell.
         # If LIT_USE_INTERNAL_SHELL is in the environment, we use that as an
         # override.
         lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
         if lit_shell_env:
             self.use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
-            if not self.use_lit_shell and lit_config.update_tests:
-                print("note: --update-tests is not supported when using external shell")
 
         if not self.use_lit_shell:
             features.add("shell")

lit/main.py

@@ -42,7 +42,6 @@ def main(builtin_params={}):
         config_prefix=opts.configPrefix,
         per_test_coverage=opts.per_test_coverage,
         gtest_sharding=opts.gtest_sharding,
-        update_tests=opts.update_tests,
     )
 
     discovered_tests = lit.discovery.find_tests_for_inputs(