Skip to content

Commit c04ad95

Browse files
[lit] Move pipefail test into lit tests
These removes another test that otherwise needs a shell. This does remove test coverage for pipefail in the external shell, but the external shell should be disabled by default pretty soon. This also adds test coverage for the internal shell which did not exist before. Reviewers: jh7370, ilovepi, petrhosek Reviewed By: ilovepi, petrhosek Pull Request: llvm/llvm-project#157223
1 parent 3bf4efa commit c04ad95

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Check that we fail if earlier operations in a pipe fail.
2+
#
3+
# RUN: false | echo test
4+
#

tests/shtest-shell.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,11 @@
580580
# CHECK: # error: command failed with exit status: 127
581581
# CHECK: ***
582582

583+
# CHECK: FAIL: shtest-shell :: pipefail.txt
584+
# CHECK: *** TEST 'shtest-shell :: pipefail.txt' FAILED ***
585+
# CHECK: error: command failed with exit status: 1
586+
# CHECK: ***
587+
583588
# CHECK: PASS: shtest-shell :: redirects.txt
584589

585590
# CHECK: FAIL: shtest-shell :: rm-error-0.txt
@@ -629,4 +634,4 @@
629634

630635
# CHECK: PASS: shtest-shell :: valid-shell.txt
631636
# CHECK: Unresolved Tests (1)
632-
# CHECK: Failed Tests (36)
637+
# CHECK: Failed Tests (37)

0 commit comments

Comments
 (0)