Skip to content

Commit 01d95d2

Browse files
committed
Drop custom request class
We only use this class when we check if a request is for a JSON API endpoint. After that it is not used After upgrading to Rails 5, enough of the internals changed making this custom class difficult to support. I think initially the idea was this would be a Rack only mix-in. However, at this point we use enough of `ActionDispatch` / `ActiveSupport` to make it a bit of work to be pure Rack. Since we're accepting that we're a Rails plugin let's just embrace it and use `ActionDispatch` objects directly; thus we drop our custom class.
1 parent df1e57d commit 01d95d2

File tree

2 files changed

+0
-121
lines changed

2 files changed

+0
-121
lines changed

lib/kracken/json_api.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
require_relative 'json_api/exception_wrapper'
22
require_relative 'json_api/path'
33
require_relative 'json_api/public_exceptions'
4-
require_relative 'json_api/request'
54
require_relative 'json_api/routing_mapper'
65

76
module Kracken

lib/kracken/json_api/request.rb

Lines changed: 0 additions & 120 deletions
This file was deleted.

0 commit comments

Comments
 (0)