Drop auth cache prefixes

As the auth caches are no now internal we do not need the extra key
prefixes. The prefixes were meant to simply reduce key name collisions;
which being an internal cache is not an issue.

Author: cupakromer

lib/kracken/authenticator.rb

@@ -34,7 +34,7 @@ def self.user_with_token(token)
       # for the user, set it to nil, fetch from cache and only query if there
       # was a cache-hit (thus user is still nil).
       user = nil
-      user_id = Authenticator.cache.fetch("auth/#{token}/#{auth.etag}") {
+      user_id = Authenticator.cache.fetch("#{token}/#{auth.etag}") {
         user = self.new(auth.body).to_app_user
         user.id
       }

lib/kracken/controllers/token_authenticatable.rb

@@ -36,22 +36,19 @@ def request_http_token_authentication(realm = 'Application')
 
     module_function
 
-      TOKEN_AUTH_CACHE_PREFIX = "auth/token/"
-
       def cache_valid_auth(token, force: false, &generate_cache)
-        cache_key = TOKEN_AUTH_CACHE_PREFIX + token
+        cache_key = token
         val = TokenAuthenticatable.cache.read(cache_key) unless force
         val ||= store_valid_auth(cache_key, &generate_cache)
         shallow_freeze(val)
       end
 
       def clear_auth_cache
-        TokenAuthenticatable.cache.delete_matched TOKEN_AUTH_CACHE_PREFIX + "*"
+        TokenAuthenticatable.cache.clear
       end
 
       def shallow_freeze(val)
-        # `nil` is frozen in Ruby 2.2 but not in Ruby 2.1
-        return val if val.frozen? || val.nil?
+        return val if val.frozen?
         val.each { |_k, v| v.freeze }.freeze
       end
 

spec/kracken/controllers/token_authenticatable_spec.rb

@@ -65,7 +65,7 @@ def authenticate_or_request_with_http_token(realm = nil)
           }
         }
         let(:cached_token) { "any token" }
-        let(:cache_key) { "auth/token/any token" }
+        let(:cache_key) { "any token" }
 
         before do
           a_controller.request.env = {
@@ -163,7 +163,7 @@ def authenticate_or_request_with_http_token(realm = nil)
           expect {
             a_controller.authenticate_user_with_token!
           }.not_to change {
-            Controllers::TokenAuthenticatable.cache.exist?("auth/token/#{invalid_token}")
+            Controllers::TokenAuthenticatable.cache.exist?("#{invalid_token}")
           }.from false
         end
       end
@@ -222,7 +222,7 @@ def authenticate_or_request_with_http_token(realm = nil)
           expect {
             a_controller.authenticate_user_with_token!
           }.to change {
-            Controllers::TokenAuthenticatable.cache.read("auth/token/any token")
+            Controllers::TokenAuthenticatable.cache.read("any token")
           }.from(nil).to(
             id: :any_id,
             team_ids: [:some, :team, :ids],
@@ -231,7 +231,7 @@ def authenticate_or_request_with_http_token(realm = nil)
 
         it "sets the cache expiration to one minute by default" do
           expect(Controllers::TokenAuthenticatable.cache).to receive(:write).with(
-            "auth/token/any token",
+            "any token",
             anything,
             include(expires_in: 1.minute),
           )