Skip to content

Commit 6cfc630

Browse files
committed
Fix warnings
/app/controllers/kracken/sessions_controller.rb:11: warning: assigned but unused variable - current_user /lib/kracken/config.rb:7: warning: instance variable @provider_url not initialized /lib/kracken/config.rb:11: warning: instance variable @user_class not initialized /lib/kracken/controllers/authenticatable.rb:95: warning: instance variable @current_user not initialized
1 parent ffd3101 commit 6cfc630

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

app/controllers/kracken/sessions_controller.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ def index
88

99
def create
1010
@user = user_class.find_or_create_from_auth_hash(auth_hash)
11-
current_user = @user
1211
session[:user_id] = @user.id
1312
session[:user_cache_key] = cookies[:_radius_user_cache_key]
1413
session[:token_expires_at] = Time.zone.at(auth_hash[:credentials][:expires_at])

lib/kracken/config.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ class Config
44
attr_writer :provider_url, :user_class
55

66
def provider_url
7-
@provider_url || PROVIDER_URL
7+
@provider_url ||= PROVIDER_URL
88
end
99

1010
def user_class
11-
@user_class || ::User
11+
@user_class ||= ::User
1212
end
1313
end
1414
end

lib/kracken/controllers/authenticatable.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ def current_user=(u)
9292
end
9393

9494
def current_user
95-
return @current_user if @current_user
96-
fetch_current_user
95+
@current_user ||= fetch_current_user
9796
end
9897

9998
def fetch_current_user

0 commit comments

Comments
 (0)