Skip to content

Commit 9751a10

Browse files
committed
Only include radius-spec/rubocop/reviewdog for 2.5
1 parent 0898fef commit 9751a10

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,5 @@ gemspec
1717

1818
rails_dependencies_gemfile = File.expand_path("../Gemfile-rails-dependencies", __FILE__)
1919
eval_gemfile rails_dependencies_gemfile
20+
21+
gem 'radius-spec', require: false, group: %i[development test] if RUBY_VERSION.to_f >= 2.5

bin/ci

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,13 @@ export RACK_ROOT="$RAILS_ROOT"
1717
echo " ---> Running tests"
1818
./bin/rspec --require rails_helper
1919

20-
# Script for running Rubocop
21-
# A Ruby static code analyzer, based on the community Ruby style guide.
22-
# http://rubocop.readthedocs.io
23-
echo " ---> Running rubocop"
24-
./bin/rubocop --config .rubocop.yml --lint
20+
if [ "$TRAVIS_RUBY_VERSION" = "2.5.0" ]; then
21+
# Script for running Rubocop
22+
# A Ruby static code analyzer, based on the community Ruby style guide.
23+
# http://rubocop.readthedocs.io
24+
echo " ---> Running rubocop"
25+
./bin/rubocop --config .rubocop.yml --lint
26+
fi
2527

2628
# Script for running Brakeman tests
2729
# Brakeman is a security scanner

bin/ci-code-review

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ if [[ "$TRAVIS_PULL_REQUEST" = "false" ]] || [[ "$TRAVIS_BRANCH" = "production"
1212
exit
1313
fi
1414

15+
if ! [ "$TRAVIS_RUBY_VERSION" = "2.5.0" ]; then
16+
exit
17+
fi
18+
1519
set -e
1620
cd "$(dirname "$0")/.."
1721

kracken.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,5 @@ Gem::Specification.new do |s|
2727
s.add_development_dependency 'rspec-rails', '~> 3.5'
2828
s.add_development_dependency 'pry'
2929
s.add_development_dependency 'pry-nav'
30-
s.add_development_dependency 'radius-spec', '~> 0.4'
3130
s.add_development_dependency 'webmock'
3231
end

0 commit comments

Comments
 (0)