Fix Rubocop lint warnings

    lib/kracken/controllers/json_api_compatible.rb:108:7: W: Lint/UselessAccessModifier: Useless private access modifier.
          private
          ^^^^^^^
    lib/kracken/controllers/token_authenticatable.rb:28:70: W: Lint/UnusedMethodArgument: Unused method argument - message. If it's necessary, use _ or _message as an argument name to indicate that it won't be used.
            def request_http_token_authentication(realm = 'Application', message = nil)
                                                                         ^^^^^^^
    lib/kracken/controllers/token_authenticatable.rb:118:30: W: Lint/AssignmentInCondition: Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
                if @current_user = Authenticator.user_with_token(token)
                                 ^
    lib/kracken/engine.rb:9:40: W: Lint/UnusedBlockArgument: Unused block argument - app. You can omit the argument if you don't care about it.
        initializer "kracken.omniauth" do |app|
                                           ^^^
    lib/kracken/env.rb:11:1: W: Lint/HandleExceptions: Do not suppress exceptions.
    rescue LoadError
    ^^^^^^^^^^^^^^^^
    lib/kracken/json_api/public_exceptions.rb:64:7: W: Lint/RescueException: Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
          rescue Exception => exception ...
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    lib/kracken/json_api/public_exceptions.rb:83:32: W: Lint/UnusedMethodArgument: Unused method argument - error. If it's necessary, use _ or _error as an argument name to indicate that it won't be used. You can also write as additional_details(*) if you want the method to accept any arguments but don't care about them.
            def additional_details(error)
                                   ^^^^^
    lib/kracken.rb:20:19: W: Lint/UnusedMethodArgument: Unused method argument - block. If it's necessary, use _ or _block as an argument name to indicate that it won't be used. You can also write as setup(*) if you want the method to accept any arguments but don't care about them.
      def self.setup(&block)
                      ^^^^^
    lib/omniauth/strategies/radius.rb:8:1: W: Lint/HandleExceptions: Do not suppress exceptions.
    rescue LoadError
    ^^^^^^^^^^^^^^^^
    lib/omniauth/strategies/radius.rb:29:11: W: Lint/UnneededSplatExpansion: Pass array contents as separate arguments.
              *%w{ ...
              ^^^^
    spec/kracken/controllers/token_authenticatable_spec.rb:19:49: W: Lint/UnusedMethodArgument: Unused method argument - realm. If it's necessary, use _ or _realm as an argument name to indicate that it won't be used. You can also write as authenticate_or_request_with_http_token(*) if you want the method to accept any arguments but don't care about them.
        def authenticate_or_request_with_http_token(realm = nil)
                                                    ^^^^^
    spec/requests/api_spec.rb:17:28: W: Lint/UnusedMethodArgument: Unused method argument - path. If it's necessary, use _ or _path as an argument name to indicate that it won't be used.
          def request_resource(path, params: {}, headers: {})
                               ^^^^
    spec/requests/api_spec.rb:21:28: W: Lint/UnusedMethodArgument: Unused method argument - path. If it's necessary, use _ or _path as an argument name to indicate that it won't be used.
          def request_resource(path, params: {}, headers: {})
                               ^^^^

Author: cupakromer

lib/kracken.rb

@@ -17,7 +17,7 @@ module Kracken
   mattr_accessor :config
   @@config = Config.new
 
-  def self.setup(&block)
+  def self.setup
     yield @@config
   end
 end

lib/kracken/controllers/json_api_compatible.rb

@@ -105,9 +105,8 @@ def negotiate_mime
           raise ::ActionController::UnknownFormat
         end
 
-      private
-
         ALLOWED_MEDIA_TYPES = [Mime[:json]].freeze
+        private_constant :ALLOWED_MEDIA_TYPES
       end
       include DataIntegrity
 

lib/kracken/controllers/token_authenticatable.rb

@@ -25,7 +25,7 @@ def self.included(base)
       #
       # Modified from https://github.com/rails/rails/blob/60d0aec7/actionpack/lib/action_controller/metal/http_authentication.rb#L490-L499
       if Rails::VERSION::MAJOR >= 5
-        def request_http_token_authentication(realm = 'Application', message = nil)
+        def request_http_token_authentication(realm = 'Application', _message = nil)
           headers["WWW-Authenticate"] = %(Token realm="#{realm.gsub(/"/, "")}")
           raise TokenUnauthorized, "Invalid Credentials"
         end
@@ -115,7 +115,7 @@ def authenticate_user_with_token!
         authenticate_or_request_with_http_token(realm) { |token, _options|
           # Attempt to reduce ivar namespace conflicts with controllers
           @_auth_info = cache_valid_auth(token) {
-            if @current_user = Authenticator.user_with_token(token)
+            if (@current_user = Authenticator.user_with_token(token))
               { id: @current_user.id, team_ids: @current_user.team_ids }
             end
           }

lib/kracken/engine.rb

@@ -6,7 +6,7 @@ module Kracken
   class Engine < ::Rails::Engine
     isolate_namespace Kracken
 
-    initializer "kracken.omniauth" do |app|
+    initializer "kracken.omniauth" do |_app|
       Rails.application.config.middleware.use OmniAuth::Builder do
         provider :radius, Kracken.config.app_id, Kracken.config.app_secret
       end

lib/kracken/env.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 # If this gem is loaded via bundler before the rails initializer we need to
@@ -8,7 +7,8 @@
 begin
   require 'dotenv'
   Dotenv.load
-rescue LoadError
+rescue LoadError => e
+  raise unless e.message.include?('dotenv')
 end
 
 module Kracken

lib/kracken/json_api/public_exceptions.rb

@@ -61,7 +61,7 @@ def capture_error(env)
         end
 
         response
-      rescue Exception => exception
+      rescue Exception => exception # rubocop:disable Lint/RescueException
         wrapper = exception_wrapper(env, exception)
         log_error(env, wrapper)
         render_json_error(wrapper)
@@ -80,7 +80,7 @@ def exception_wrapper(env, exception)
       end
 
       if Rails.env.production?
-        def additional_details(error)
+        def additional_details(_error)
           {}
         end
       else

lib/omniauth/strategies/radius.rb

@@ -5,7 +5,8 @@
 begin
   require 'dotenv'
   Dotenv.load
-rescue LoadError
+rescue LoadError => e
+  raise unless e.message.include?('dotenv')
 end
 
 module OmniAuth
@@ -26,17 +27,15 @@ def self.provider_url
 
       info do
         raw_info["info"].slice(
-          *%w{
-            first_name
-            last_name
-            email
-            uid
-            confirmed
-            teams
-            linked_accounts
-            admin
-            subscription_level
-          }
+          "first_name",
+          "last_name",
+          "email",
+          "uid",
+          "confirmed",
+          "teams",
+          "linked_accounts",
+          "admin",
+          "subscription_level",
         )
       end
 

spec/kracken/controllers/token_authenticatable_spec.rb

@@ -16,7 +16,7 @@ class TokenAuthController < BaseControllerDouble
            :current_user,
            :current_user_id
 
-    def authenticate_or_request_with_http_token(realm = nil)
+    def authenticate_or_request_with_http_token(_realm = nil)
       /\AToken token="(?<token>.*)"\z/ =~ request.env['HTTP_AUTHORIZATION']
       yield token if block_given?
     end

spec/requests/api_spec.rb

@@ -14,11 +14,11 @@ def headers_with_token(token)
 
     # Temporary work around while we support versions of Rails before 4
     if Rails::VERSION::MAJOR >= 5
-      def request_resource(path, params: {}, headers: {})
+      def request_resource(_path, params: {}, headers: {})
         get api_index_path, params: params, headers: headers
       end
     else
-      def request_resource(path, params: {}, headers: {})
+      def request_resource(_path, params: {}, headers: {})
         get api_index_path, params, headers
       end
     end