Skip to content

Commit c924141

Browse files
committed
Remove ApplicationController from SessonsController
Turns out that rails 5 had different autoloading behavior, and was autoloading `Kracken::ApplicationController` when it referenced "ApplicationController` in the `Kracken` module. I am not sure who had the better behavior, rails 4 or rails 5, but this could be resolved by dropping the dependency on the `ApplicationController` and just inheriting from `ActionController::Base` directly. Once I did that just needed to remove the `skip_before_filters` and things seemed to work.
1 parent b4d62c9 commit c924141

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

app/controllers/kracken/application_controller.rb

Lines changed: 0 additions & 4 deletions
This file was deleted.

app/controllers/kracken/sessions_controller.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
module Kracken
2-
class SessionsController < ApplicationController
3-
skip_before_filter :authenticate_user!, except: [:index]
4-
skip_before_filter :handle_user_cache_cookie!, except: [:index]
5-
6-
def index
7-
end
2+
class SessionsController < ActionController::Base
83

94
def create
105
@user = user_class.find_or_create_from_auth_hash(auth_hash)

0 commit comments

Comments
 (0)