Skip to content

Commit ed281ad

Browse files
committed
Extract shared sign-in shim logic
This makes it easier in the future to provide the `sign_out` parity when we want include the `sign_in` helper. We name the module as a "shim" to help indicate the behavior of the module; i.e. shimming in some logic, instead of changing a configuration, intercepting remote auth calls, etc.
1 parent bbd4d45 commit ed281ad

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

lib/kracken/rspec.rb

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,18 @@ def self.current_user=(current_user)
1212
@@current_user = current_user
1313
end
1414

15-
module Request
15+
module SignInShim
1616
def sign_in(user = nil)
1717
Kracken::SpecHelper.current_user = user
1818
end
1919

2020
def sign_out(_ignored = nil)
2121
Kracken::SpecHelper.current_user = nil
2222
end
23+
end
24+
25+
module Request
26+
include SignInShim
2327

2428
def token_authorize(user, token:)
2529
Kracken::Controllers::TokenAuthenticatable::cache_valid_auth(token, force: true) do
@@ -29,21 +33,13 @@ def token_authorize(user, token:)
2933
end
3034

3135
module Controller
32-
def sign_in(user = nil)
33-
Kracken::SpecHelper.current_user = user
34-
end
35-
36-
def sign_out(_ignored = nil)
37-
Kracken::SpecHelper.current_user = nil
38-
end
36+
include SignInShim
3937

4038
def current_user
4139
Kracken::SpecHelper.current_user
4240
end
4341
end
44-
4542
end
46-
4743
end
4844

4945
# monkey patch current_user

0 commit comments

Comments
 (0)