rewrote PathUtil to work with file.getParentFile

Justification: relying on getParentFile gets the path splitting working  under windows and unix

- adapted the tests to the new behavior
- added a windows / unix switch in the tests to get them working on both systems

PathUtils now converts:
- the empty path to an empty List
- an absolute path to a list folders (not including the drive name under windows)
- a relative path to a list of folders

Author: MichaelZinsmaier

plugin/src/main/scala/com/buransky/plugins/scoverage/util/PathUtil.scala

@@ -20,15 +20,24 @@
 package com.buransky.plugins.scoverage.util
 
 import java.io.File
+import scala.Iterator
 /**
  *  File path helper.
  *
  * @author Rado Buransky
  */
 object PathUtil {
-  def splitPath(filePath: String, separator: String = File.separator): List[String] =
-    filePath.split(separator.replaceAllLiterally("\\", "\\\\")).toList match {
-      case "" :: tail if tail.nonEmpty => separator :: tail
-      case other => other
-    }
-}
+  
+  def splitPath(filePath: String): List[String] = {
+    new FileParentIterator(new File(filePath)).toList.reverse
+  }
+  
+  class FileParentIterator(private var f: File) extends Iterator[String] {
+    def hasNext: Boolean = f != null && !f.getName().isEmpty()
+    def next(): String = {
+      val name = f.getName()
+      f = f.getParentFile
+      name
+    } 
+  }
+}

plugin/src/test/scala/com/buransky/plugins/scoverage/util/PathUtilSpec.scala

@@ -24,23 +24,30 @@ import org.junit.runner.RunWith
 import org.scalatest.junit.JUnitRunner
 
 @RunWith(classOf[JUnitRunner])
-class UnixPathUtilSpec extends ParamPathUtilSpec("Unix", "/")
-
-@RunWith(classOf[JUnitRunner])
-class WindowsPathUtilSpec extends ParamPathUtilSpec("Windows", "\\")
-
-abstract class ParamPathUtilSpec(osName: String, separator: String) extends FlatSpec with Matchers {
+class PathUtilSpec extends FlatSpec with Matchers {
+  
+  val osName = System.getProperty("os.name")
+  val separator = System.getProperty("file.separator")
+  
   behavior of s"splitPath for $osName"
-
-  it should "work for empty path" in {
-    PathUtil.splitPath("", separator) should equal(List(""))
+  
+  it should "ignore the empty path" in {
+    PathUtil.splitPath("") should equal(List.empty[String])
   }
 
-  it should "work with separator at the beginning" in {
-    PathUtil.splitPath(s"${separator}a", separator) should equal(List(separator, "a"))
+  it should "ignore a separator at the beginning" in {
+    PathUtil.splitPath(s"${separator}a") should equal(List("a"))
   }
 
   it should "work with separator in the middle" in {
-    PathUtil.splitPath(s"a${separator}b", separator) should equal(List("a", "b"))
+    PathUtil.splitPath(s"a${separator}b") should equal(List("a", "b"))
+  }
+  
+  it should "work with an OS dependent absolute path" in {
+    if (osName.startsWith("Windows")) {
+      PathUtil.splitPath("C:\\test\\2") should equal(List("test", "2"))
+    } else {
+      PathUtil.splitPath("/test/2") should equal(List("test", "2"))
+    }
   }
 }