Skip to content

Commit 5b4bd5b

Browse files
committed
refactor(tests/nixos/s3-binary-cache-store): inline make_http_url fn
Remove make_http_url helper function and inline its single usage.
1 parent 4ae6c65 commit 5b4bd5b

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

tests/nixos/s3-binary-cache-store.nix

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,6 @@ in
103103
bucket_and_path = f"{bucket}{path}" if path else bucket
104104
return f"s3://{bucket_and_path}?{query}"
105105
106-
def make_http_url(path):
107-
"""Build HTTP URL for direct S3 access"""
108-
return f"{ENDPOINT}/{path}"
109-
110106
def get_package_hash(pkg_path):
111107
"""Extract store hash from package path"""
112108
return pkg_path.split("/")[-1].split("-")[0]
@@ -208,7 +204,7 @@ in
208204
print("\n=== Testing Error Message Formatting ===")
209205
210206
nonexistent_url = make_s3_url(bucket, path="/foo-that-does-not-exist")
211-
expected_http_url = make_http_url(f"{bucket}/foo-that-does-not-exist")
207+
expected_http_url = f"{ENDPOINT}/{bucket}/foo-that-does-not-exist"
212208
213209
error_msg = client.fail(
214210
f"{ENV_WITH_CREDS} nix eval --impure --expr "

0 commit comments

Comments
 (0)