Merge branch '161-update-values-when-switching-property-type'

Author: RafaelGB

docs/docs/changelog.md

@@ -7,7 +7,7 @@
 - Now you can hide completed task on task column type [ISSUE#111](https://github.com/RafaelGB/obsidian-db-folder/issues/111)
 ### No longer broken
 - If you modify the label of a column, now exist an onMouseLeave event to blur the input and be more frieldly to the user interact with the next action without a double click (once for onBlur label edition and another for your next interaction) [ISSUE#114](https://github.com/RafaelGB/obsidian-db-folder/issues/114)
-## 1.7.2
+- Change the type of the column to checkbox respects the value `1` as marked and will not mark as `0` all by default[ISSUE#161](https://github.com/RafaelGB/obsidian-db-folder/issues/161)
 ### No longer broken
 - add new rows hotfix. Was broken in 1.7.1 with refactor of datadispatch
 ## 1.7.1

src/__tests__/IO/settings.test.ts

@@ -1,4 +1,5 @@
 import { YamlHandlerResponse } from "cdm/MashallModel";
+import { mockReset, mockDeep, DeepMockProxy } from "jest-mock-extended";
 import { parseYamlMock } from "mock/mockObsidianUtils";
 import DatabaseStringToYamlParser from "parsers/DatabaseStringToYamlParser";
 
@@ -8,12 +9,20 @@ jest.mock("obsidian",
         return {
             parseYaml: jest.fn(() => {
                 return parseYamlMock(1, 1);
-            }
-            ),
+            }),
         };
     }
 );
 describe("Settings", () => {
+    // @ts-ignore
+    const mockGlobalApp: DeepMockProxy<App> = mockDeep<App>();
+    /**
+     * Run this before each test.
+     */
+    beforeAll(() => {
+        mockReset(mockGlobalApp);
+        global.app = mockGlobalApp;
+    });
     /** Parse string YAML */
     test("Parse Database string to Yaml", () => {
         const yamlResponse: YamlHandlerResponse = DatabaseStringToYamlParser("test");

src/components/modals/handlers/tasks/HideCompletedTaskToggleHandler.ts

@@ -6,7 +6,7 @@ export class HideCompletedTaskToggleHandler extends AbstractColumnHandler {
     handle(columnHandlerResponse: ColumnHandlerResponse): ColumnHandlerResponse {
         const { column, containerEl, view } = columnHandlerResponse;
         const inline_togle_promise = async (value: boolean): Promise<void> => {
-            column.config.isInline = value;
+            column.config.task_hide_completed = value;
             // Persist value
             await view.diskConfig.updateColumnConfig(column.key, {
                 task_hide_completed: value

src/helpers/Constants.ts

@@ -242,7 +242,7 @@ export function getOperatorFilterValue(keyToFind: string): string {
 }
 
 export const MarkdownBreakerRules = Object.freeze({
-  INIT_CHARS: ['`', '\"', '[', '{', '*'],
+  INIT_CHARS: ['`', '"', '[', '{', '*'],
   BETWEEN_CHARS: [':'],
   UNIQUE_CHARS: ['?'],
 })

src/helpers/VaultManagement.ts

@@ -98,10 +98,12 @@ export async function sourceDataviewPages(folderPath: string, dbYaml: DatabaseYa
       pagesResult = DataviewService.getDataviewAPI().pages(`outgoing([[${dbYaml.config.source_form_result}]])`);
       break;
     case SourceDataTypes.QUERY:
-      const query = generateDataviewTableQuery(
-        dbYaml.columns,
-        dbYaml.config.source_form_result)
-      pagesResult = await obtainQueryResult(query, folderPath);
+      pagesResult = await obtainQueryResult(
+        generateDataviewTableQuery(
+          dbYaml.columns,
+          dbYaml.config.source_form_result),
+        folderPath
+      );
       break;
     default:
       pagesResult = DataviewService.getDataviewAPI().pages(`"${folderPath}"`);
@@ -129,7 +131,7 @@ async function obtainQueryResult(query: string, folderPath: string): Promise<Dat
     const msg = `Error obtaining query result: "${query}", current folder loaded instead`;
     LOGGER.error(msg, error);
     new Notice(msg, 10000);
-    return DataviewService.getDataviewAPI().pages(`"${folderPath}"`);;
+    return DataviewService.getDataviewAPI().pages(`"${folderPath}"`);
   }
 }
 

src/mock/mockObsidianUtils.ts

@@ -1,27 +1,13 @@
-import { parseYaml } from "obsidian";
+import { generateYamlColumns } from "mock/mockTableUtils";
+import { DEFAULT_SETTINGS } from "helpers/Constants";
 
 /** Mock parseYaml returning YamlHandlerResponse object */
 export const parseYamlMock = (numOfColumns: number, numberOfFilters: number) => {
     return {
         name: "Test",
         description: "Test",
-        columns: {
-            "test": {
-                input: "text",
-                accessor: "test",
-                label: "test",
-                key: "test",
-                position: 1,
-                isMetadata: true,
-                skipPersist: false,
-                csvCandidate: true,
-                isInline: false
-            }
-        },
-        config: {
-            enable_show_state: false,
-            group_folder_column: "test"
-        },
+        columns: generateYamlColumns(numOfColumns),
+        config: DEFAULT_SETTINGS.local_settings,
         filters: [
             {
                 field: "test",

src/mock/mockTableUtils.tsx

@@ -2,7 +2,7 @@
 import faker from "@faker-js/faker";
 import React, { useRef, useLayoutEffect } from "react";
 import { randomColor } from "helpers/Colors";
-import { DataTypes } from "helpers/Constants";
+import { DataTypes, DEFAULT_COLUMN_CONFIG } from "helpers/Constants";
 import { TableDataType, TableColumn, RowDataType } from "cdm/FolderModel";
 import { DatabaseColumn } from "cdm/DatabaseModel";
 import { obtainColumnsFromFolder } from "components/Columns";
@@ -36,7 +36,6 @@ export async function makeData(count: number): Promise<TableDataType> {
     skipReset: false,
     view: null,
     stateManager: null,
-    cellSize: "normal",
   };
 }
 
@@ -60,12 +59,7 @@ export const generateYamlColumns = (
       isMetadata: false,
       skipPersist: true,
       csvCandidate: false,
-      config: {
-        enable_media_view: true,
-        media_width: 100,
-        media_height: 100,
-        isInline: false,
-      },
+      config: DEFAULT_COLUMN_CONFIG,
     };
   }
   return yamlColumns;

src/services/DataviewService.ts

@@ -152,8 +152,12 @@ class DataviewProxy {
     }
 
     private parseToNumber(wrapped: WrappedLiteral): number {
-        const adjustedValue = this.getDataviewAPI().value.toString(wrapped.value);
-        return wrapped.type === 'number' ? wrapped.value : Number(adjustedValue);
+        if (wrapped.type === 'number') {
+            return wrapped.value;
+        } else {
+            const adjustedValue = this.getDataviewAPI().value.toString(wrapped.value);
+            return Number(adjustedValue);
+        }
     }
 
     private parseToMarkdown(wrapped: WrappedLiteral, localSettings: LocalSettings, isInline: boolean): string {