Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit 596093e

Browse files
committed
filters modal done
1 parent 37fd586 commit 596093e

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

src/components/modals/filters/FiltersModal.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { StyleClasses } from "helpers/Constants";
66
import { Modal } from "obsidian";
77
import { add_setting_header } from "settings/SettingsComponents";
88
import { filter_group_section } from "components/modals/filters/FilterGroupSection";
9+
import { t } from "lang/helpers";
910

1011
export class FiltersModal extends Modal {
1112
addColumnManager: FiltersModalManager;
@@ -37,7 +38,7 @@ export class FiltersModalManager {
3738
constructUI(containerEl: HTMLElement) {
3839
/** Common modal headings */
3940
containerEl.addClass(StyleClasses.FILTERS_MODAL);
40-
add_setting_header(containerEl, `Table Filters`, "h2");
41+
add_setting_header(containerEl, t("filters_modal_title"), "h2");
4142

4243
const addColumnBody = containerEl.createDiv();
4344
addColumnBody.addClass(StyleClasses.FILTERS_MODAL_BODY);

src/components/modals/newColumn/handlers/QuickOptionsColumnsHandler.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Setting } from "obsidian";
77
import { AbstractHandlerClass } from "patterns/chain/AbstractHandler";
88

99
export class QuickOptionsColumnsHandler extends AbstractHandlerClass<AddColumnModalHandlerResponse> {
10-
settingTitle: string = "Column quick options";
10+
settingTitle: string = t("add_row_modal_quick_options_title");
1111
handle(
1212
response: AddColumnModalHandlerResponse
1313
): AddColumnModalHandlerResponse {
@@ -50,17 +50,17 @@ export class QuickOptionsColumnsHandler extends AbstractHandlerClass<AddColumnMo
5050
// Cross column settings
5151
const columnSetting = new Setting(containerEl)
5252
.setName(column.label)
53-
.setDesc(`Quick options of ${column.label}${column.isMetadata ? " (metadata)" : ""}`)
53+
.setDesc(`${t("add_row_modal_quick_options_desc", column.label)}${column.isMetadata ? t("add_row_modal_quick_options_desc_metadata") : ""}`)
5454
.addToggle(toggle =>
5555
toggle
5656
.setValue(!column.isHidden)
5757
.onChange(toggleHandler)
58-
.setTooltip(`Show or hide ${column.label}`)
58+
.setTooltip(t("add_row_modal_quick_options_desc_tooltip", column.label))
5959
)
6060
.addButton(button => {
6161
button
6262
.setIcon("gear")
63-
.setTooltip(`Open settings of ${column.label}`)
63+
.setTooltip(t("add_row_modal_quick_options_desc_button_add_tooltip"))
6464
.onClick(openSettingsHandler)
6565
});
6666
// Add extra options for non-metadata columns
@@ -77,10 +77,13 @@ export class QuickOptionsColumnsHandler extends AbstractHandlerClass<AddColumnMo
7777
.addButton(button => {
7878
button
7979
.setIcon("trash")
80-
.setTooltip(`Delete ${column.label}`)
80+
.setTooltip(t("add_row_modal_quick_options_desc_button_delete_tooltip", column.label))
8181
.onClick(async () => {
8282
const confirmation = await new ConfirmModal()
83-
.setMessage(`Are you sure you want to delete ${column.label}?`)
83+
.setMessage(t(
84+
"add_row_modal_quick_options_desc_button_delete_notice_confirm",
85+
column.label
86+
))
8487
.isConfirmed();
8588
if (confirmation) {
8689
columnState.actions.remove(column);

src/lang/locale/en.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,13 @@ export default {
9898
"add_row_modal_add_existing_column_button_tooltip": "Create the selected column and refresh the table",
9999
"add_row_modal_add_existing_notice_error_empty": "You need to select a column to add",
100100
"add_row_modal_add_existing_notice_correct": "{0} added to the table",
101+
"add_row_modal_quick_options_title": "Column quick options",
102+
"add_row_modal_quick_options_desc": "Quick options of {0}",
103+
"add_row_modal_quick_options_desc_metadata": " (Metadata)",
104+
"add_row_modal_quick_options_desc_tooltip": "Show or hide {0}",
105+
"add_row_modal_quick_options_desc_button_add_tooltip": "Open settings of {0}",
106+
"add_row_modal_quick_options_desc_button_delete_tooltip": "Delete {0}",
107+
"add_row_modal_quick_options_desc_button_delete_notice_confirm": "Are you sure you want to delete {0}?",
108+
/** FILTERS MODAL */
109+
"filters_modal_title": "Table filters",
101110
};

0 commit comments

Comments
 (0)