IMPROVED TAGS

Author: RafaelGB

src/helpers/Constants.ts

@@ -408,7 +408,7 @@ export const DEFAULT_SETTINGS: DatabaseSettings = {
     show_metadata_inlinks: false,
     show_metadata_outlinks: false,
     source_data: SourceDataTypes.CURRENT_FOLDER,
-    source_form_result: 'root',
+    source_form_result: '',
     source_destination_path: '/',
     row_templates_folder: '/',
     current_row_template: '',

src/helpers/VaultManagement.ts

@@ -127,8 +127,7 @@ export async function sourceDataviewPages(ddbbConfig: LocalSettings, folderPath:
         pagesResult = await obtainQueryResult(
           generateDataviewTableQuery(
             columns,
-            ddbbConfig.source_form_result),
-          folderPath
+            ddbbConfig.source_form_result)
         );
         break;
       case SourceDataTypes.CURRENT_FOLDER_WITHOUT_SUBFOLDERS:
@@ -146,13 +145,13 @@ export async function sourceDataviewPages(ddbbConfig: LocalSettings, folderPath:
   } catch (error) {
     const msg = `Error obtaining pages result. Current folder loaded instead`;
     LOGGER.error(msg, error);
-    new Notice(msg, 10000);
+    new Notice(msg, 4000);
     pagesResult = DataviewService.getDataviewAPI().pages(`"${folderPath}"`);
   }
   return pagesResult;
 }
 
-async function obtainQueryResult(query: string, folderPath: string): Promise<DataArray<Record<string, Literal>>> {
+async function obtainQueryResult(query: string): Promise<DataArray<Record<string, Literal>>> {
   const result = await DataviewService.getDataviewAPI().query(query);
   if (!result.successful || result.value.type !== 'table') {
     throw new Error(`Query ${query} failed`);

src/settings/handlers/source/flavours/TagsSourceBuilder.ts

@@ -46,17 +46,17 @@ export class TagSourceBuilder {
                     });
 
                 cb.inputEl.style.width = "auto";
-            }).addExtraButton((button) => {
-                button.setIcon("cross")
+            }).addButton((button) => {
+                button.setButtonText("Reset")
                     .setTooltip(t("settings_source_form_tag_clear_button_tooltip"))
                     .onClick(async () => {
                         // Clear all tags
                         this.selectedTags = [];
-                        this.initSuggestions();
                         suggester.setSuggestions(this.tagRecords);
                         await this.view.diskConfig.updateConfig({
                             source_form_result: ""
                         });
+                        this.initSuggestions();
                         this.tagsLabel.innerHTML = "None";
                         this.tagsContainer.style.display = "none";
                     });