working

Author: RafaelGB

src/Settings.ts

@@ -17,6 +17,7 @@ interface GlobalSettings {
 export interface LocalSettings {
   enable_show_state: boolean;
   group_folder_column: string;
+  remove_field_when_delete_column: boolean;
 }
 export interface DatabaseSettings {
   global_settings: GlobalSettings;
@@ -30,6 +31,7 @@ export const DEFAULT_SETTINGS: DatabaseSettings = {
   },
   local_settings: {
     enable_show_state: false,
+    remove_field_when_delete_column: false,
     group_folder_column: ''
   }
 };

src/components/reducers/DatabaseDispatch.tsx

@@ -323,17 +323,19 @@ export function databaseReducer(state: TableDataType, action: ActionType) {
       );
       // Update configuration on disk
       state.view.diskConfig.removeColumn(action.columnId);
-      Promise.all(
-        state.data.map(async (row: RowDataType) => {
-          updateRowFile(
-            row.note.getFile(),
-            action.key,
-            undefined, // delete does not need this field
-            state,
-            UpdateRowOptions.REMOVE_COLUMN
-          );
-        })
-      );
+      if (state.view.diskConfig.yaml.config.remove_field_when_delete_column) {
+        Promise.all(
+          state.data.map(async (row: RowDataType) => {
+            updateRowFile(
+              row.note.getFile(),
+              action.key,
+              undefined, // delete does not need this field
+              state,
+              UpdateRowOptions.REMOVE_COLUMN
+            );
+          })
+        );
+      }
       // Update state
       return update(state, {
         skipReset: { $set: true },

src/parsers/DatabaseYamlToStringParser.ts

@@ -24,6 +24,7 @@ const DatabaseYamlToStringParser = (databaseConfig: DatabaseYaml): string[] => {
   databaseConfigString.push(`config:`);
   databaseConfigString.push(`${yamlIndent.repeat(1)}enable_show_state: ${databaseConfig.config.enable_show_state}`);
   databaseConfigString.push(`${yamlIndent.repeat(1)}group_folder_column: ${databaseConfig.config.group_folder_column}`);
+  databaseConfigString.push(`${yamlIndent.repeat(1)}remove_field_when_delete_column: ${databaseConfig.config.remove_field_when_delete_column}`);
 
   // Database filters
   if (databaseConfig.filters) {

src/parsers/handlers/ConfigHandler.ts

@@ -18,6 +18,12 @@ export class ConfigHandler extends AbstractYamlHandler {
                 this.addError(`There was not group_folder_column key in yaml. Default will be loaded`);
                 this.localYaml.config.group_folder_column = '';
             }
+            // if remove_field_when_delete_column is not defined, load default
+            if (handlerResponse.yaml.config.remove_field_when_delete_column === undefined) {
+                this.addError(`There was not remove_field_when_delete_column key in yaml. Default will be loaded`);
+                this.localYaml.config.remove_field_when_delete_column = false;
+            }
+
         }
         return this.goNext(handlerResponse);
     }

src/settings/ColumnsSection.ts

@@ -1,6 +1,7 @@
 import { add_setting_header } from 'settings/SettingsComponents';
 import { SettingHandler, SettingHandlerResponse } from 'settings/handlers/AbstractSettingHandler';
 import { GroupFolderColumnDropDownHandler } from 'settings/handlers/columns/GroupFolderColumnDropDownHandler';
+import { RemoveFieldsWhenDeleteToggleHandler } from 'settings/handlers/columns/RemoveFieldsWhenDeleteToggleHandler';
 
 /**
  * developer settings section
@@ -25,6 +26,7 @@ export function columns_settings_section(settingHandlerResponse: SettingHandlerR
  */
 function getHandlers(): SettingHandler[] {
     return [
-        new GroupFolderColumnDropDownHandler()
+        new GroupFolderColumnDropDownHandler(),
+        new RemoveFieldsWhenDeleteToggleHandler()
     ];
 }

src/settings/handlers/columns/RemoveFieldsWhenDeleteToggleHandler.ts

@@ -0,0 +1,31 @@
+import { add_toggle } from "settings/SettingsComponents";
+import { AbstractSettingsHandler, SettingHandlerResponse } from "settings/handlers/AbstractSettingHandler";
+export class RemoveFieldsWhenDeleteToggleHandler extends AbstractSettingsHandler {
+    settingTitle: string = 'Remove fields';
+    handle(settingHandlerResponse: SettingHandlerResponse): SettingHandlerResponse {
+        const { settingsManager, containerEl, local, view } = settingHandlerResponse;
+        const remove_fields_toggle_promise = async (value: boolean): Promise<void> => {
+            // Check context to define correct promise
+            if (local) {
+                // Persist value
+                view.diskConfig.updateConfig('remove_field_when_delete_column', value);
+            } else {
+                // switch remove fields on/off
+                const update_local_settings = settingsManager.plugin.settings.local_settings;
+                update_local_settings.remove_field_when_delete_column = value;
+                // update settings
+                await settingsManager.plugin.updateSettings({
+                    local_settings: update_local_settings
+                });
+            }
+        }
+        add_toggle(
+            containerEl,
+            this.settingTitle,
+            "Enable/disable remove fields when delete a column",
+            local ? view.diskConfig.yaml.config.remove_field_when_delete_column : settingsManager.plugin.settings.local_settings.remove_field_when_delete_column,
+            remove_fields_toggle_promise
+        );
+        return this.goNext(settingHandlerResponse);
+    }
+}