changes of Liam review

Author: RafaelGB

src/components/Cell.tsx

@@ -43,6 +43,12 @@ export default function DefaultCell(cellProperties: Cell) {
     `<=> Cell.rendering dataType: ${dataType}. value: ${value.value}`
   );
 
+  const handleKeyDown = (event: any) => {
+    if (event.key === "Enter") {
+      console.log("blur on enter");
+      event.target.blur();
+    }
+  };
   // onChange handler
   const handleOnChange = (event: ContentEditableEvent) => {
     // cancelling previous timeouts
@@ -54,19 +60,19 @@ export default function DefaultCell(cellProperties: Cell) {
     // initialize a setimeout by wrapping in our editNoteTimeout so that we can clear it out using clearTimeout
     setEditNoteTimeout(
       setTimeout(() => {
-        onChange(event);
+        onChange(event.target.value);
         // timeout until event is triggered after user has stopped typing
       }, 1500)
     );
   };
 
-  function onChange(event: ContentEditableEvent) {
+  function onChange(changedValue: string) {
     // save on disk
     dataDispatch({
       type: ActionTypes.UPDATE_CELL,
       file: note.getFile(),
       key: (cellProperties.column as any).key,
-      value: event.target.value,
+      value: changedValue,
       row: cellProperties.row,
       columnId: (cellProperties.column as any).id,
     });
@@ -80,6 +86,7 @@ export default function DefaultCell(cellProperties: Cell) {
           <ContentEditable
             html={(value.value && value.value.toString()) || ""}
             onChange={handleOnChange}
+            onKeyDown={handleKeyDown}
             onBlur={() =>
               setValue((old) => ({ value: old.value, update: true }))
             }

src/helpers/FileContent.ts

@@ -5,7 +5,7 @@ export class FileContent {
     }
 
     object(): string[] {
-        return this.real_array(this.value.split('\n'));
+        return this.value.split('\n');
     }
 
     replaceAll(pattern_to_replace: RegExp, input: string): FileContent {
@@ -36,7 +36,7 @@ export class FileContent {
                 delete _object[index];
             }
         });
-        this.value = this.real_array(_object).join('\n');
+        this.value = _object.join('\n');
         return this;
     }
 
@@ -47,7 +47,7 @@ export class FileContent {
                 delete _object[index];
             }
         });
-        this.value = this.real_array(_object).join('\n');
+        this.value = _object.join('\n');
         return this;
     }
 
@@ -64,15 +64,7 @@ export class FileContent {
     edit(content: string, line_number: number): FileContent {
         const _object = this.object();
         _object[line_number - 1] = content;
-        this.value = this.real_array(_object).join('\n');
+        this.value = _object.join('\n');
         return this;
     }
-
-    real_array(array: string[]): string[] {
-        const output: string[] = [];
-        array.forEach(element => {
-            output.push(element);
-        });
-        return output;
-    }
 }

src/services/FileManagerService.ts

@@ -69,7 +69,12 @@ export class VaultManager {
    * @returns 
    */
   obtainTfileFromFilePath(filePath: string): TFile {
-    return app.vault.getMarkdownFiles().find(tfile => tfile.path === filePath);
+    const abstractFile = app.vault.getAbstractFileByPath(filePath);
+    if (abstractFile instanceof TFile) {
+      return abstractFile;
+    } else {
+      throw "Error: File " + filePath + " is not a TFile";
+    }
   }
 
   /**