Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit 809ecd2

Browse files
committed
particular settings text
1 parent 8142c69 commit 809ecd2

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

src/components/modals/ColumnModal.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Modal } from "obsidian";
44
import { add_setting_header } from "settings/SettingsComponents";
55
import { ActionTypes, StyleClasses } from "helpers/Constants";
66
import { ColumnHandlerResponse } from "cdm/ModalSettingsModel";
7-
import { media_settings_section, behavior_settings_section } from "components/modals/ColumnSections";
7+
import { particular_settings_section, behavior_settings_section } from "components/modals/ColumnSections";
88
import { HeaderMenuProps } from "cdm/HeaderModel";
99
import { Dispatch } from "react";
1010

@@ -66,8 +66,8 @@ export class ColumnSettingsManager {
6666
constructBody(settingHandlerResponse: ColumnHandlerResponse) {
6767
/** behavior section */
6868
behavior_settings_section(settingHandlerResponse);
69-
/** media section */
70-
media_settings_section(settingHandlerResponse);
69+
/** Particular settings section */
70+
particular_settings_section(settingHandlerResponse);
7171
}
7272

7373
reset(response: ColumnHandlerResponse) {

src/components/modals/ColumnSections.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,15 @@ export function behavior_settings_section(settingHandlerResponse: ColumnHandlerR
2626
return handlers[0].handle(settingHandlerResponse);
2727
}
2828

29-
export function media_settings_section(settingHandlerResponse: ColumnHandlerResponse): ColumnHandlerResponse {
30-
const folder_section = settingHandlerResponse.containerEl.createDiv("column-section-container-media");
29+
export function particular_settings_section(settingHandlerResponse: ColumnHandlerResponse): ColumnHandlerResponse {
30+
const particular_section = settingHandlerResponse.containerEl.createDiv("column-section-container-particular");
3131
// title of the section
32-
add_setting_header(folder_section, "Media adjustments", 'h3');
32+
add_setting_header(particular_section, `Particular properties of "${settingHandlerResponse.column.dataType
33+
}" column type`, 'h3');
3334
/**
3435
* Obtain all classes than extends from AbstractHandler
3536
*/
3637
const handlers = [
37-
new MediaToggleHandler(),
38-
new MediaDimensionsHandler(),
3938
...addParticularInputSettings(settingHandlerResponse.column.dataType)
4039
]
4140
let i = 1;
@@ -44,13 +43,17 @@ export function media_settings_section(settingHandlerResponse: ColumnHandlerResp
4443
i++;
4544
}
4645

47-
settingHandlerResponse.containerEl = folder_section;
46+
settingHandlerResponse.containerEl = particular_section;
4847
return handlers[0].handle(settingHandlerResponse);
4948
}
5049

5150
function addParticularInputSettings(dataType: string): ColumnHandler[] {
5251
const particularHandlers: ColumnHandler[] = [];
5352
switch (dataType) {
53+
case DataTypes.TEXT:
54+
particularHandlers.push(new MediaToggleHandler());
55+
particularHandlers.push(new MediaDimensionsHandler());
56+
break;
5457
case DataTypes.SELECT:
5558
particularHandlers.push(new SelectedColumnOptionsHandler());
5659
break;

0 commit comments

Comments
 (0)