Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit 91f0808

Browse files
committed
Merge branch 'parsing_between_improvements'
2 parents ec26328 + 0b4acd9 commit 91f0808

File tree

6 files changed

+23
-9
lines changed

6 files changed

+23
-9
lines changed

src/helpers/VaultManagement.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,5 +170,9 @@ async function obtainQueryResult(query: string, folderPath: string): Promise<Dat
170170
}
171171
}
172172

173-
174-
173+
export function obtainCellFromFile(path: string, column: TableColumn): Literal {
174+
const page = DataviewService.getDataviewAPI().page(path) as NoteInfoPage;
175+
const noteInfo = new NoteInfo(page);
176+
const uniqueRowValue = noteInfo.getRowDataType([column]);
177+
return uniqueRowValue[column.id] as Literal;
178+
}

src/lang/locale/en.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,11 @@ export default {
317317
"settings_source_title": "Select the source of database data",
318318
"settings_source_desc": "Select from which source you want to get the data to be displayed in the table.",
319319
"settings_source_form_title": "Form in function of source data",
320-
"settings_source_form_tag_title": "Select a tag",
321-
"settings_source_form_tag_desc": "Select a tag to use as source of data",
320+
"settings_source_form_tag_title": "Data Source Tags",
321+
"settings_source_form_tag_desc": "Select the tags you want as data source. You can add multiple tags.",
322322
"settings_source_form_tag_placeholder": "Select a tag...",
323+
"settings_source_form_tag_clear_button_tooltip": "Clear all tags",
324+
"settings_source_form_tag_selected": "Selected Tags: ",
323325
"settings_source_form_file_title": "Select a file",
324326
"settings_source_form_file_desc": "Select a file to use as source of data",
325327
"settings_source_form_file_placeholder": "Example: folder1/template_file",

src/lang/locale/es.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,8 @@ export default {
320320
"settings_source_form_tag_title": "Seleccionar una etiqueta",
321321
"settings_source_form_tag_desc": "Seleccionar una etiqueta para usar como fuente de datos",
322322
"settings_source_form_tag_placeholder": "Ejemplo: #tag",
323+
"settings_source_form_tag_clear_button_tooltip": "Limpiar todas las etiquetas",
324+
"settings_source_form_tag_selected": "Etiquetas seleccionadas",
323325
"settings_source_form_file_title": "Seleccionar un archivo",
324326
"settings_source_form_file_desc": "Seleccionar un archivo para usar como fuente de datos",
325327
"settings_source_form_file_placeholder": "Buscar archivo...",

src/lang/locale/fr.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,8 @@ export default {
320320
"settings_source_form_tag_title": "Sélectionner un tag",
321321
"settings_source_form_tag_desc": "Sélectionner un tag à utiliser comme source de données.",
322322
"settings_source_form_tag_placeholder": "Sélectionner un tag...",
323+
"settings_source_form_tag_clear_button_tooltip": "Effacer le tag sélectionné",
324+
"settings_source_form_tags_selected": "Tags sélectionnés :",
323325
"settings_source_form_file_title": "Sélectionner un fichier",
324326
"settings_source_form_file_desc": "Sélectionner un fichier à utiliser comme source de données.",
325327
"settings_source_form_file_placeholder": "Exemple : fichier1/fichier_modèle",

src/settings/handlers/source/flavours/TagsSourceBuilder.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ export class TagSourceBuilder {
2323
let suggester: StringSuggest;
2424

2525
new Setting(this.containerEl)
26-
.setName("Data Source Tags")
27-
.setDesc("Select the tags you want as data source. You can add multiple tags.")
26+
.setName(t("settings_source_form_tag_title"))
27+
.setDesc(t("settings_source_form_tag_desc"))
2828
.addSearch((cb) => {
2929
suggester = new StringSuggest(
3030
cb.inputEl,
3131
this.tagRecords
3232
);
33-
cb.setPlaceholder("Select a tag")
33+
cb.setPlaceholder(t("settings_source_form_tag_placeholder"))
3434
.onChange(async (value: string): Promise<void> => {
3535
if (value && this.tagRecords[value]) {
3636
// update settings
@@ -47,7 +47,7 @@ export class TagSourceBuilder {
4747
cb.inputEl.style.width = "auto";
4848
}).addExtraButton((button) => {
4949
button.setIcon("cross")
50-
.setTooltip("Clear all tags")
50+
.setTooltip(t("settings_source_form_tag_clear_button_tooltip"))
5151
.onClick(async () => {
5252
// Clear all tags
5353
this.selectedTags = [];
@@ -67,7 +67,7 @@ export class TagSourceBuilder {
6767
private configureTagDisplay = () => {
6868
this.tagsContainer = this.containerEl.createEl("div");
6969
const label = this.containerEl.createEl("span", {
70-
text: "Selected Tags: ",
70+
text: t("settings_source_form_tag_selected"),
7171
});
7272
label.style.color = "#666";
7373
this.tagsContainer.appendChild(label);

src/stateManagement/data/handlers/ParseDataOfColumnHandlerAction.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { TableColumn } from "cdm/FolderModel";
22
import { LocalSettings } from "cdm/SettingsModel";
33
import { DataState, TableActionResponse } from "cdm/TableStateInterface";
4+
import { obtainCellFromFile } from "helpers/VaultManagement";
45
import { ParseService } from "services/ParseService";
56
import { AbstractTableAction } from "stateManagement/AbstractTableAction";
67

@@ -10,6 +11,9 @@ export default class ParseDataOfColumnHandlerAction extends AbstractTableAction<
1011
implementation.actions.parseDataOfColumn = (column: TableColumn, input: string, ddbbConfig: LocalSettings) =>
1112
set((updater) => {
1213
const parsedRows = updater.rows.map((row) => {
14+
// Recover original value
15+
const dvCell = obtainCellFromFile(row.__note__.filepath, column);
16+
row[column.key] = dvCell;
1317
// Transform the input into the target type
1418
const parsedValue = ParseService.parseRowToCell(
1519
row,

0 commit comments

Comments
 (0)