Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit c5b2c28

Browse files
committed
reset setting correctly
1 parent 6344bd1 commit c5b2c28

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/settings/handlers/media/MediaDimensionsHandler.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ export class MediaDimensionsHandler extends AbstractSettingsHandler {
5959
media_settings.width = settingsManager.settings.local_settings.media_settings.width;
6060
media_settings.height = settingsManager.settings.local_settings.media_settings.height;
6161
view.diskConfig.updateConfig('media_settings', media_settings);
62+
// Force refresh of settings
63+
settingsManager.reset(settingHandlerResponse);
6264
});
6365
});
6466
}

src/settings/handlers/media/MediaToggleHandler.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,30 @@ export class MediaToggleHandler extends AbstractSettingsHandler {
55
handle(settingHandlerResponse: SettingHandlerResponse): SettingHandlerResponse {
66
const { settingsManager, containerEl, local, view } = settingHandlerResponse;
77
// pass if modal opened from local settings
8-
8+
const media_settings = local ? view.diskConfig.yaml.config.media_settings : settingsManager.plugin.settings.local_settings.media_settings;
99
const media_togle_promise = async (value: boolean): Promise<void> => {
10+
media_settings.enable_media_view = value;
1011
// Check context to define correct promise
1112
if (local) {
1213
// Persist value
13-
const { media_settings } = view.diskConfig.yaml.config;
14-
media_settings.enable_media_view = value;
1514
view.diskConfig.updateConfig('media_settings', media_settings);
1615
} else {
1716
// switch media state on/off
1817
const update_local_settings = settingsManager.plugin.settings.local_settings;
19-
update_local_settings.media_settings.enable_media_view = value;
18+
update_local_settings.media_settings = media_settings;
2019
// update settings
2120
await settingsManager.plugin.updateSettings({
2221
local_settings: update_local_settings
2322
});
2423
}
24+
// Force refresh of settings
25+
settingsManager.reset(settingHandlerResponse);
2526
}
2627
add_toggle(
2728
containerEl,
2829
this.settingTitle,
2930
"Enable/disable wrap media links with embedding content",
30-
settingsManager.plugin.settings.local_settings.media_settings.enable_media_view,
31+
media_settings.enable_media_view,
3132
media_togle_promise
3233
);
3334
return this.goNext(settingHandlerResponse);

0 commit comments

Comments
 (0)