Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Commit cf3fe2b

Browse files
committed
fixing rollup source fields on dv query
1 parent 8268ce9 commit cf3fe2b

File tree

8 files changed

+17
-17
lines changed

8 files changed

+17
-17
lines changed

src/automations/Footer.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { DEFAULT_SETTINGS, FooterType } from "helpers/Constants";
22
import { Literal } from "obsidian-dataview";
33
import { DataviewService } from "services/DataviewService";
4-
import { DateTime } from "luxon";
54
import { DbAutomationService } from "services/AutomationService";
65

76
export default class Footer {

src/components/Columns.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,14 @@ export async function obtainColumnsFromFile(
149149
}
150150

151151
export async function obtainColumnsFromRows(
152-
view: DatabaseView,
152+
folderPath: string,
153153
ddbbConfig: LocalSettings,
154154
filters: FilterSettings,
155155
tableColumns: TableColumn[]
156156
): Promise<string[]> {
157157
const columns: string[] = [];
158158
const rows = await obtainAllPossibleRows(
159-
view.file.parent.path,
159+
folderPath,
160160
ddbbConfig,
161161
filters,
162162
tableColumns

src/components/modals/columnSettings/handlers/rollups/RollupKeyHandler.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export class RollupKeyHandler extends AbstractHandlerClass<ColumnSettingsHandler
2626
});
2727
columnSettingsManager.modal.enableReset = true;
2828
};
29+
2930
recordFieldsFromRelation(
3031
relationColumn.config.related_note_path,
3132
configState.info.getLocalSettings(),

src/components/modals/filters/handlers/DataviewFiltersComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const DataviewFiltersComponent = (props: DataviewFiltersProps) => {
2020
emptyFilterConditions.conditions = [];
2121
resolve(
2222
obtainColumnsFromRows(
23-
view,
23+
view.file.parent.path,
2424
configInfo.getLocalSettings(),
2525
emptyFilterConditions,
2626
columnsInfo.getAllColumns()

src/components/modals/newColumn/handlers/AddExistingColumnHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class AddExistingColumnHandler extends AbstractHandlerClass<AddColumnModa
2121

2222
const promiseOfObtainColumnsFromRows = new Promise<string[]>((resolve) => {
2323
resolve(obtainColumnsFromRows(
24-
addColumnModalManager.addColumnModal.view,
24+
addColumnModalManager.addColumnModal.view.file.parent.path,
2525
configState.info.getLocalSettings(),
2626
configState.info.getFilters(),
2727
columns

src/components/reducers/DataviewFilters.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default function EditFiltersButton(props: DataviewFiltersProps) {
2323
emptyFilterConditions.conditions = [];
2424
resolve(
2525
obtainColumnsFromRows(
26-
view,
26+
view.file.parent.path,
2727
configInfo.getLocalSettings(),
2828
emptyFilterConditions,
2929
columns

src/helpers/RelationHelper.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import DatabaseInfo from "services/DatabaseInfo";
66
import { sourceDataviewPages } from "helpers/VaultManagement";
77
import { LocalSettings } from "cdm/SettingsModel";
88
import { TableColumn } from "cdm/FolderModel";
9+
import { obtainColumnsFromRows } from "components/Columns";
910

1011
/**
1112
* Search for all databases in the vault returning a Record of all databases
@@ -43,17 +44,16 @@ export async function recordFieldsFromRelation(ddbbPath: string, ddbbConfig: Loc
4344
const relationFields: Record<string, string> = {};
4445
const ddbbFile = resolve_tfile(ddbbPath);
4546
const ddbbInfo = new DatabaseInfo(ddbbFile);
46-
ddbbInfo.initDatabaseconfigYaml(ddbbConfig);
47-
const ddbbRows = await sourceDataviewPages(ddbbConfig, ddbbFile.parent.path, columns);
47+
await ddbbInfo.initDatabaseconfigYaml(ddbbConfig);
48+
const fields = await obtainColumnsFromRows(
49+
ddbbFile.parent.path,
50+
ddbbInfo.yaml.config,
51+
ddbbInfo.yaml.filters,
52+
columns);
4853
// get unique fields from all rows
49-
ddbbRows.forEach((page) => {
54+
fields.forEach((field) => {
5055
// iterate over all fields in the row
51-
Object.keys(page).forEach((key) => {
52-
if (relationFields[key] === undefined) {
53-
relationFields[key] = key;
54-
}
55-
});
56-
}
57-
);
56+
relationFields[field] = field;
57+
});
5858
return relationFields;
5959
}

src/settings/handlers/columns/TemplateColumnsHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class TemplateColumnsHandler extends AbstractSettingsHandler {
7373
.onClick(async (): Promise<void> => {
7474
const recordColumns: Record<string, DatabaseColumn> = {};
7575
const allColumns = await obtainColumnsFromRows(
76-
view,
76+
view.file.parent.path,
7777
view.diskConfig.yaml.config,
7878
view.diskConfig.yaml.filters,
7979
columns);

0 commit comments

Comments
 (0)