Merge branch 'control_errors'

Author: RafaelGB

src/DatabaseView.tsx

@@ -64,12 +64,12 @@ export class DatabaseView extends TextFileView implements HoverParent {
     if (file) {
       this.file = file;
       this.plugin.removeView(this);
-      this.plugin.addView(this, this.data);
+      this.plugin.addView(this);
     } else {
       this.register(
         this.containerEl.onWindowMigrated(() => {
           this.plugin.removeView(this);
-          this.plugin.addView(this, this.data);
+          this.plugin.addView(this);
         })
       );
     }
@@ -93,7 +93,7 @@ export class DatabaseView extends TextFileView implements HoverParent {
       return;
     }
 
-    this.plugin.addView(this, data);
+    this.plugin.addView(this);
   }
 
   getIcon() {

src/cdm/ServicesModel.ts

@@ -23,17 +23,11 @@ export abstract class TypeParser<T> {
         return this;
     }
 
-    public beforeParse(...args: unknown[]) {
-        // Do nothing
-    }
-
     public parse(wrapped: WrappedLiteral): T {
-        this.beforeParse();
         return wrapped.value as T;
     }
 
     public parseLiteral = (wrapped: WrappedLiteral): T => {
-        this.beforeParse();
         const parsed = this.parse(wrapped);
         return parsed;
     }

src/cdm/TableStateInterface.ts

@@ -106,7 +106,7 @@ export interface AutomationState {
         getFormula: (name: string) => unknown;
         runFormula: (input: string, row: RowDataType, dbbConfig: LocalSettings) => Literal;
         dispatchFooter: (column: TableColumn, colValues: Literal[]) => Literal;
-        dispatchRollup: (configColumn: ConfigColumn, relation: Literal, ddbbConfig: LocalSettings) => Literal;
+        dispatchRollup: (configColumn: ConfigColumn, relation: Literal) => Literal;
     },
     actions: {
         loadFormulas: (ddbbConfig: LocalSettings) => Promise<void>;

src/commands/addDatabaseHelper/databaseHelperCreationModal.ts

@@ -62,7 +62,7 @@ export class DatabaseHelperCreationModalManager {
                     });
             });
         const sourceOptions: Record<string, string> = {};
-        Object.entries(SourceDataTypes).forEach(([key, value]) => {
+        Object.entries(SourceDataTypes).forEach(([, value]) => {
             sourceOptions[value] = t(value);
         });
 
@@ -149,7 +149,7 @@ export class DatabaseHelperCreationModalManager {
     }
 
     tagHandler(containerEl: HTMLElement) {
-        const tagArray: Record<string, number> = (app.metadataCache as unknown as any).getTags();
+        const tagArray: Record<string, number> = app.metadataCache.getTags();
         if (tagArray) {
             const tagRecords: Record<string, string> = {};
             // Order tagRecord by key (tag name)

src/components/behavior/ArrowKeysNavigation.ts

@@ -12,23 +12,26 @@ const onKeyDownArrowKeys: KeyboardEventHandler<HTMLDivElement> = (event) => {
     const index = Array.from(currentTr.children).indexOf(currentTd);
 
     switch (event.key) {
-        case "ArrowLeft":
+        case "ArrowLeft": {
             // Left pressed
             const TdLeft = currentTd.previousElementSibling;
             if (!TdLeft) break;
             const TdLeftTabIndex = TdLeft.getElementsByClassName(c('tabIndex'))[0] as TabIndexElement;
             if (!TdLeftTabIndex) break;
             TdLeftTabIndex.focus();
             break;
-        case "ArrowRight":
+        }
+
+        case "ArrowRight": {
             // Right pressed
             const TdRight = currentTd.nextElementSibling;
             if (!TdRight) break;
             const TdRightTabIndex = TdRight.getElementsByClassName(c('tabIndex'))[0] as TabIndexElement;
             if (!TdRightTabIndex) break;
             TdRightTabIndex.focus();
             break;
-        case "ArrowUp":
+        }
+        case "ArrowUp": {
             // Up pressed
             const TrUp = currentTr
                 .previousElementSibling
@@ -41,7 +44,8 @@ const onKeyDownArrowKeys: KeyboardEventHandler<HTMLDivElement> = (event) => {
             if (!TdUp) break;
             TdUp.focus();
             break;
-        case "ArrowDown":
+        }
+        case "ArrowDown": {
             // Down pressed
             const TrDown = currentTr
                 .nextElementSibling
@@ -54,6 +58,7 @@ const onKeyDownArrowKeys: KeyboardEventHandler<HTMLDivElement> = (event) => {
             if (TdDown === undefined) break;
             TdDown.focus();
             break;
+        }
     }
 }
 

src/components/cellTypes/Editor/filepicker.ts

@@ -310,12 +310,14 @@ async function getBlocks(
   }
 
   try {
+    const cachedMetadata = app.metadataCache.getFileCache(file);
+
     const blockCache = await (app.metadataCache as any).blockCache.getForFile(
       new MockRunnable(),
       file
     );
 
-    if (!blockCache?.blocks) {
+    if (!cachedMetadata?.blocks) {
       return callback([]);
     }
 

src/components/cellTypes/RollupCell.tsx

@@ -36,11 +36,7 @@ const RollupCell = (mdProps: CellComponentProps) => {
         return;
       }
       const rollupResponse = formulaInfo
-        .dispatchRollup(
-          tableColumn.config,
-          relation as Literal,
-          configInfo.getLocalSettings()
-        )
+        .dispatchRollup(tableColumn.config, relation as Literal)
         .toString();
 
       MarkdownService.renderMarkdown(

src/components/modals/TextModal.ts

@@ -41,8 +41,7 @@ export class TextModal extends Modal {
     createForm(): void {
         const div = this.contentEl.createDiv();
         div.addClass(c("prompt-modal"));
-        let textInput;
-        textInput = new TextComponent(div);
+        const textInput = new TextComponent(div);
         this.value = this.default_value ?? "";
         textInput.inputEl.addClass(c("text-modal"));
         textInput.setPlaceholder(this.placeholder);

src/components/modals/addRow/AddRowModal.ts

@@ -16,7 +16,7 @@ export class AddRowModal extends Modal {
     state: AddRowModalProps;
     dataState: Partial<DataState>;
     configState: Partial<ConfigState>;
-    enableReset: boolean = false;
+    enableReset = false;
     constructor(
         props: AddRowModalProps
     ) {

src/components/modals/addRow/handlers/FilenameTextHandler.ts

@@ -4,8 +4,8 @@ import { Setting } from "obsidian";
 import { AbstractHandlerClass } from "patterns/chain/AbstractHandler";
 
 export class FilenameTextHandler extends AbstractHandlerClass<AddRowModalHandlerResponse> {
-    settingTitle: string = t("add_row_modal_filename_text_title");
-    textElId: string = "AddRowModalManager-addRow-input";
+    settingTitle = t("add_row_modal_filename_text_title");
+    textElId = "AddRowModalManager-addRow-input";
     handle(
         response: AddRowModalHandlerResponse
     ): AddRowModalHandlerResponse {