-
Notifications
You must be signed in to change notification settings - Fork 27
Make bapctools pip-installable #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@niklasmohrin Looks like there have been some changes on |
|
I checked the box now, but actually I think I would prefer to just do the rebase myself, it's not too bad and gives me less anxiety than multiple people force pushing a branch :D I will not work on this this weekend, so feel free to push as many conflicts as you want to main :) I will write a regex for the rebase |
|
Haha, all right! I'll delay the import rewrites from #473 (comment) anyway, but good to hear that the rebasing won't be an issue for you 🙂 |
|
I updated the PR description with the current information and my thoughts on what to do next. I think I am happy with the current state of the PR. Let me know what you think about the PR and the proposed next steps. When merging: Please squash everything :) |
|
I'm also happy with the current state and the list of things to do after merging this PR, thanks a ton! 😄 ❤️ Because we have NWERC coming up (30 November), we'll wait with merging this until after that contest. Then we'll also have more time to do a thorough review 🙂 I'll keep using your branch during problem development to see if things break (so far, so good)! In the mean time, feel free to investigate some of the follow-ups if you have the time (also fine if you don't have the time) 😄 |
Closes #136
To test out the installation from the branch:
pip install 'git+https://github.com/niklasmohrin/BAPCtools.git@module' bt --helpTasks:
bin/tools.py(optionally, make it warn about deprecation)Things to double-check in review:
What this PR does not do, but what can be done next: