Fix a few clippy warnings

Rebased-by: Rahix <[email protected]>

Author: Robert Forsman

avr-hal-generic/src/adc.rs

@@ -184,7 +184,7 @@ where
             // Measurement on current pin completed
             (Some(channel), false) if *channel == pin.channel() => {
                 self.reading_channel = None;
-                Ok(self.p.raw_read_adc().into())
+                Ok(self.p.raw_read_adc())
             }
             // Measurement on other pin is ongoing
             (Some(_), _) => {
@@ -298,7 +298,7 @@ macro_rules! impl_adc {
         $(#[$channel_attr])*
         impl $channel_ty {
             pub fn into_channel(self) -> $crate::adc::Channel<$HAL, $ADC> {
-                crate::adc::Channel::new(self)
+                $crate::adc::Channel::new(self)
             }
         }
         )*)?

avr-hal-generic/src/i2c.rs

@@ -404,7 +404,7 @@ macro_rules! impl_i2c_twi {
             > for $I2C
         {
             #[inline]
-            fn raw_setup<CLOCK: crate::clock::Clock>(&mut self, speed: u32) {
+            fn raw_setup<CLOCK: $crate::clock::Clock>(&mut self, speed: u32) {
                 // Calculate TWBR register value
                 let twbr = ((CLOCK::FREQ / speed) - 16) / 2;
                 self.twbr.write(|w| unsafe { w.bits(twbr as u8) });

avr-hal-generic/src/usart.rs

@@ -79,10 +79,10 @@ impl<CLOCK: crate::clock::Clock> Baudrate<CLOCK> {
 
     fn compare_value(&self) -> u32 {
         if self.u2x {
-            return 8 * (self.ubrr as u32 + 1);
+            8 * (self.ubrr as u32 + 1)
         } else {
-            return 16 * (self.ubrr as u32 + 1);
-        };
+            16 * (self.ubrr as u32 + 1)
+        }
     }
 }
 

examples/arduino-uno/src/bin/uno-ext-interrupt.rs

@@ -10,15 +10,14 @@
 #![feature(abi_avr_interrupt)]
 
 use panic_halt as _;
-use core::ops::Range;
 use core::sync::atomic::{AtomicBool, Ordering};
 use arduino_hal::port::{mode, Pin};
 use either::*;
 
 static REVERSED: AtomicBool = AtomicBool::new(false);
 
 fn is_reversed() -> bool {
-    return REVERSED.load(Ordering::SeqCst);
+    REVERSED.load(Ordering::SeqCst)
 }
 
 #[avr_device::interrupt(atmega328p)]
@@ -27,7 +26,7 @@ fn INT0() {
     REVERSED.store(!current, Ordering::SeqCst);
 }
 
-fn blink_for_range(range : Range<u16>, leds : &mut[Pin<mode::Output>]) {
+fn blink_for_range(range: impl Iterator<Item = u16>, leds: &mut [Pin<mode::Output>]) {
     range.map(|i| i * 100).for_each(|ms| {
         let iter = if is_reversed() {
             Left(leds.iter_mut().rev())
@@ -63,6 +62,6 @@ fn main() -> ! {
 
     loop {
         blink_for_range(0..10, &mut leds);
-        blink_for_range(10..0, &mut leds);
+        blink_for_range((0..10).rev(), &mut leds);
     }
 }

examples/arduino-uno/src/bin/uno-i2cdetect.rs

@@ -40,5 +40,7 @@ fn main() -> ! {
     i2c.i2cdetect(&mut serial, arduino_hal::i2c::Direction::Read)
         .void_unwrap();
 
-    loop {}
+    loop {
+        arduino_hal::delay_ms(1000);
+    }
 }

examples/arduino-uno/src/bin/uno-infrared.rs

@@ -1,4 +1,3 @@
-
 /*!
  * Example for receiving IR signals from a remote control using an [Irdroino] shield
  * and the [Infrared] crate.

examples/arduino-uno/src/bin/uno-pin-change-interrupt.rs

@@ -9,10 +9,9 @@
 #![no_main]
 #![feature(abi_avr_interrupt)]
 
-use arduino_hal;
 use panic_halt as _;
 
-use core:: sync::atomic::{AtomicBool, Ordering};
+use core::sync::atomic::{AtomicBool, Ordering};
 
 static PIN_CHANGED: AtomicBool = AtomicBool::new(false);
 
@@ -42,11 +41,11 @@ fn main() -> ! {
     //Pins used to drive the stepper motor
     let mut dir_pin = pins.d4.into_output();
     let mut step_pin = pins.d5.into_output();
-    
+
     //Rotary encoder attached on these pins
     let rotary_pins = [
         pins.d2.into_floating_input().downgrade(), //CLK
-        pins.d3.into_floating_input().downgrade() //DT
+        pins.d3.into_floating_input().downgrade(), //DT
     ];
 
     // Enable the PCINT2 pin change interrupt