DCE Removing Commands

[vurvdev]

Dunno if you'd consider this an issue, but with --dce full commands get removed, maybe there's a way through the Compiler/Context class or something to stop this automatically.

It confused me for a while and some people might want to use dce everywhere else without putting @:keep on their CommandBot class / all of the commands.

[RaidAndFade]

That's natural, your command is considered "Dead code" because it is not referenced during compile time. @:keep is the correct resolution.

Alternatively, don't do --dce at all, since realistically it wont help much in an app like this

[vurvdev]

Yes, but the problem is that this is unclear and confusing to deal with.
It could easily be fixed just by adding @:keepSub to the CommandBot parent class.

Ideally you would make a macro like this (Unfinished code. Think you'd just use https://api.haxe.org/haxe/macro/Compiler.html?#keep)?

@:autoBuild(KeepCommands.keep())
class CommandBot {}

class Test extends CommandBot {
	static function main() {
		// Setup
	}

	@Command
	function ping(message) {
		message.react("✅");
		message.reply({content: "Pong!"});
	}
}

import haxe.macro.Context;
import haxe.macro.Expr;

class KeepCommands {
	macro static function keep():Array<Field> {
		final t = Context.getLocalType();
		switch (t) {
			case TInst(typ, params):
				// Check for functions that have @Command metadata, and @:keep them
			default:
				// Compile error
				throw "";
		}
		return null;
	}
}