Skip to content

Commit 0fec425

Browse files
authored
Renamed destination_directory to icons_directory (#87)
1 parent 62eac4d commit 0fec425

File tree

7 files changed

+23
-11
lines changed

7 files changed

+23
-11
lines changed

lib/generators/rails_icons/initializer_generator.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class InitializerGenerator < RailsIcons::BaseGenerator
99
desc "Create the Rails Icons initializer."
1010

1111
class_option :libraries, type: :array, default: [], desc: "Choose libraries (#{RailsIcons.libraries.keys.join("/")})"
12-
class_option :destination, type: :string, default: RailsIcons.configuration.destination_path, desc: "Specify destination folder for icons"
12+
class_option :destination, type: :string, default: RailsIcons.configuration.icons_path, desc: "Specify icons folder"
1313
class_option :custom, type: :string, desc: "Name of the custom library"
1414

1515
def copy_initializer
@@ -32,12 +32,12 @@ def insert_default_configuration
3232
end
3333
end
3434

35-
def insert_custom_destination_path
36-
return if options[:destination] && options[:destination] == RailsIcons.configuration.destination_path
35+
def insert_custom_icons_path
36+
return if options[:destination] && options[:destination] == RailsIcons.configuration.icons_path
3737

3838
insert_into_file INITIALIZER, <<~RB.indent(2), after: "RailsIcons.configure do |config|\n"
39-
# Default destination path
40-
config.destination_path = "#{options[:destination]}"
39+
# Default icons path
40+
config.icons_path = "#{options[:destination]}"
4141
4242
RB
4343
end

lib/generators/rails_icons/install_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class InstallGenerator < RailsIcons::BaseGenerator
99
desc "Install Rails Icons with the chosen libraries. This creates the configuration initializer and will sync the icons."
1010

1111
class_option :libraries, type: :array, default: [], desc: "Choose libraries (#{RailsIcons.libraries.keys.join("/")})"
12-
class_option :destination, type: :string, default: RailsIcons.configuration.destination_path, desc: "Specify destination folder for icons"
12+
class_option :destination, type: :string, default: RailsIcons.configuration.icons_path, desc: "Specify destination folder for icons"
1313
class_option :skip_sync, type: :boolean, default: false
1414

1515
def initializer_generator

lib/generators/rails_icons/sync_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def libraries
2121

2222
def synced_libraries
2323
RailsIcons.libraries.keys.map(&:to_s).select do |library|
24-
Dir.exist?(File.join(RailsIcons.configuration.destination_path, library.to_s))
24+
Dir.exist?(File.join(RailsIcons.configuration.icons_path, library.to_s))
2525
end
2626
end
2727
end

lib/rails_icons/configuration.rb

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,18 @@ def initialize
1717
set_libraries_config
1818
end
1919

20+
def destination_path
21+
ActiveSupport::Deprecation.new.warn("`destination_path` is deprecated. Use `icons_path` instead.")
22+
23+
@config.icons_path
24+
end
25+
26+
def destination_path=(value)
27+
ActiveSupport::Deprecation.new.warn("`destination_path=` is deprecated. Use `icons_path=` instead.")
28+
29+
@config.icons_path = value
30+
end
31+
2032
def method_missing(method_name, ...)
2133
if @config.respond_to?(method_name)
2234
@config.send(method_name, ...)
@@ -33,7 +45,7 @@ def respond_to_missing?(method_name)
3345

3446
def set_default_config
3547
@config.default_library = nil
36-
@config.destination_path = "app/assets/svg/icons"
48+
@config.icons_path = "app/assets/svg/icons"
3749
end
3850

3951
def set_libraries_config

lib/rails_icons/icon/file_path.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def app_path = Rails.root.join(*parts)
4646

4747
def parts
4848
[
49-
RailsIcons.configuration.destination_path,
49+
RailsIcons.configuration.icons_path,
5050
@library,
5151
@variant,
5252
"#{@name}.svg"

lib/rails_icons/sync/engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def remove_non_svg_files
5353
end
5454

5555
def move_library
56-
destination = File.join(RailsIcons.configuration.destination_path, @name)
56+
destination = File.join(RailsIcons.configuration.icons_path, @name)
5757

5858
FileUtils.mkdir_p(destination)
5959
FileUtils.mv(Dir.glob("#{@temp_directory}/*"), destination, force: true)

lib/rails_icons/sync/process_variants.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def remove_files_and_folders_for(paths)
6464

6565
def remove_previously_downloaded(variants)
6666
variants.each do |variant|
67-
FileUtils.rm_rf(File.join(RailsIcons.configuration.destination_path, @name, variant.to_s))
67+
FileUtils.rm_rf(File.join(RailsIcons.configuration.icons_path, @name, variant.to_s))
6868
end
6969
end
7070

0 commit comments

Comments
 (0)