Skip validation when custom library (#67)

* Skip validation when custom library

* Added tests for custom-flag

Author: eelcoj

lib/generators/rails_icons/initializer_generator.rb

@@ -47,7 +47,7 @@ def insert_libraries_configuration
     end
 
     def setup_custom_configuration
-      return "" if options[:custom].blank?
+      return if options[:custom].blank?
 
       insert_custom_configuration
       create_custom_directory
@@ -58,7 +58,7 @@ def setup_custom_configuration
     INITIALIZER = "config/initializers/rails_icons.rb"
 
     def insert_custom_configuration
-      unless File.read(INITIALIZER).include?("config.libraries.merge!")
+      unless file_contains?(INITIALIZER, "config.libraries.merge!")
         custom_default_configuration = <<~RB.indent(2)
           config.libraries.merge!(
 

lib/rails_icons/base_generator.rb

@@ -11,10 +11,34 @@ def initialize(*arguments)
     private
 
     def validate!
+      return if custom_library?
+
       raise RailsIcons::LibraryNotFound.new("") if options.libraries.empty?
       raise RailsIcons::LibraryNotFound.new(invalid_libraries.join(", ")) if invalid_libraries.any?
     end
 
     def invalid_libraries = options.libraries.map(&:to_sym).map(&:downcase).reject { RailsIcons.libraries.key?(_1) }
+
+    def custom_library? = options.custom.present?
+
+    # Uses `gsub_file` as a read-only operation to check file content. This
+    # approach is preferred over `File.read` because `gsub_file` is properly stubbed
+    # in generator tests, while `File.read` would fail in the test environment.
+    #
+    def file_contains?(path, content)
+      return false unless File.exist?(path)
+
+      result = false
+
+      gsub_file(path, /.*/) do |file_content|
+        result = file_content.include?(content)
+
+        file_content
+      end
+
+      result
+    rescue Thor::Error
+      false
+    end
   end
 end

test/generators/initializer_generator_test.rb

@@ -74,6 +74,15 @@ class InitializerGeneratorTest < Rails::Generators::TestCase
     end
   end
 
+  test "generator creates the initializer with custom library" do
+    run_generator %w[--custom=simple_icons]
+
+    assert_file "config/initializers/rails_icons.rb" do |file|
+      assert_match "simple_icons", file
+      assert_match "config.libraries.merge!", file
+    end
+  end
+
   test "generator raise RailsIcons::LibraryNotFound when no library is specified" do
     assert_raises(RailsIcons::LibraryNotFound) do
       run_generator