automatically downcase library arguments for generators (#57)

* automatically downcase library arguments for generators

To avoid issues where capitalized library name arguments causes failures on systems that employ a case-sensitive file system.
Fixes #56

* Small refactor

---------

Co-authored-by: Thomas Dippel <dipth@mjolnirm4.local>
Co-authored-by: eelco <git@eelcoj.com>

Author: 3 people

lib/generators/rails_icons/initializer_generator.rb

@@ -20,9 +20,9 @@ def insert_default_configuration
       return unless File.exist?(INITIALIZER)
       return if default_configuration_exists?
 
-      if options[:libraries].present?
+      if libraries.present?
         default_configuration = <<~RB.indent(2)
-          config.default_library = "#{options[:libraries].first}"
+          config.default_library = "#{libraries.first}"
           # config.default_variant = "" # Set a default variant for all libraries
         RB
 
@@ -76,7 +76,7 @@ def insert_custom_configuration
     def create_custom_directory = FileUtils.mkdir_p(File.join(options[:destination], options[:custom]))
 
     def library_configuration
-      options[:libraries].map { RailsIcons.libraries[_1.to_sym].initializer_config }.join("\n")
+      libraries.map { RailsIcons.libraries[_1.to_sym].initializer_config }.join("\n")
     end
 
     def custom_configuration
@@ -95,5 +95,7 @@ def default_configuration_exists?
 
       File.readlines(INITIALIZER).any? { _1.match?(line) }
     end
+
+    def libraries = options[:libraries].map(&:downcase)
   end
 end

lib/generators/rails_icons/install_generator.rb

@@ -22,6 +22,6 @@ def sync_generator
 
     private
 
-    def attributes = ["--libraries=#{options[:libraries].join(" ")}", "--destination=#{options[:destination]}"].join(" ")
+    def attributes = ["--libraries=#{options[:libraries].map(&:downcase).join(" ")}", "--destination=#{options[:destination]}"].join(" ")
   end
 end

lib/generators/rails_icons/sync_generator.rb

@@ -19,7 +19,7 @@ def sync_icons
     private
 
     def libraries
-      options[:libraries].presence || synced_libraries
+      options[:libraries].map(&:downcase).presence || synced_libraries
     end
 
     def synced_libraries

test/generators/initializer_generator_test.rb

@@ -14,13 +14,13 @@ class InitializerGeneratorTest < Rails::Generators::TestCase
     run_generator
 
     assert_file "config/initializers/rails_icons.rb" do |file|
-      refute_match "Heroicons", file
-      refute_match "Tabler", file
+      refute_match "heroicons", file
+      refute_match "tabler", file
     end
   end
 
   test "generator creates the initializer with heroicons library" do
-    run_generator %w[--libraries=heroicons]
+    run_generator %w[--libraries=Heroicons]
 
     assert_file "config/initializers/rails_icons.rb" do |file|
       assert_match "# Override Heroicon defaults", file
@@ -37,7 +37,7 @@ class InitializerGeneratorTest < Rails::Generators::TestCase
     end
   end
 
-  test "generator creates the initializer with Phosphor library" do
+  test "generator creates the initializer with phosphor library" do
     run_generator %w[--libraries=phosphor]
 
     assert_file "config/initializers/rails_icons.rb" do |file|
@@ -59,10 +59,9 @@ class InitializerGeneratorTest < Rails::Generators::TestCase
     run_generator ["--libraries", "lucide", "tabler"]
 
     assert_file "config/initializers/rails_icons.rb" do |file|
-      Rails.logger.debug "File content: #{file}"
       assert_match "# Override Lucide defaults", file
       assert_match "# Override Tabler defaults", file
-      refute_match "Heroicons", file
+      refute_match "heroicons", file
     end
   end
 end