Skip to content

Regression in v1.2.0: Optionless sync no longer works #75

@ericenns

Description

@ericenns

Starting in v1.2.0 due to #63 optionless sync provided by #45 no longer works as RailsIcons::BaseGenerator enforce presence of libraries option and fails if it is not present, see error message below:

$ bin/rails g rails_icons:sync
/home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/rails_icons-1.3.0/lib/rails_icons/base_generator.rb:18:in `validate!': No libraries were specified. Please choose from: boxicons, feather, flags, heroicons, linear, lucide, phosphor, radix, sidekickicons, tabler or weather (RailsIcons::LibraryNotFound)
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/rails_icons-1.3.0/lib/rails_icons/base_generator.rb:10:in `initialize'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/group.rb:237:in `new'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/group.rb:237:in `dispatch'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/base.rb:584:in `start'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/generators.rb:265:in `invoke'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/commands/generate/generate_command.rb:26:in `perform'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/command.rb:28:in `run'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor/invocation.rb:127:in `invoke_command'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/command/base.rb:178:in `invoke_command'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/thor-1.3.2/lib/thor.rb:538:in `dispatch'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/command/base.rb:73:in `perform'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/command.rb:65:in `block in invoke'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/command.rb:143:in `with_argv'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/command.rb:63:in `invoke'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/railties-8.0.1/lib/rails/commands.rb:18:in `<main>'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/3.3.0/bundled_gems.rb:69:in `require'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/3.3.0/bundled_gems.rb:69:in `block (2 levels) in replace_require'
        from /home/user/.asdf/installs/ruby/3.3.7/lib/ruby/gems/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from bin/rails:4:in `<main>'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions