New way of posting to slack via bot app.

Author: dysk

app/controllers/games_controller.rb

@@ -25,11 +25,10 @@ def show
   def say
     text = params[:text]
     game_id = params[:game_id]
-    gandhi_url = "https://vignette.wikia.nocookie.net/civilization/images/3/36/Gandhi_%28Civ5%29.png/revision/latest?cb=20121104232443"
     game = ReadModel::GameReadModel.find_by(id: game_id)
     client = Slack::Web::Client.new(token: game.slack_token)
     begin
-      client.chat_postMessage(channel: game.slack_channel, text: text, as_user: false, icon_url: gandhi_url)
+      client.chat_postMessage(channel: game.slack_channel, text: text)
     rescue => e
       puts(e.inspect)
     end

notifications/lib/notifications/slack_notifier.rb

@@ -27,8 +27,6 @@ def new_turn_notification(event)
       client.chat_postMessage(
         channel: game.slack_channel,
         text: game.build_slack_new_turn_message(event.data),
-        as_user: false,
-        icon_url: gandhi_url
       )
     end
 
@@ -44,17 +42,11 @@ def maybe_notify_remaining_players(event)
           client.chat_postMessage(
             channel: game.slack_channel,
             text: "Turn " + remaining_players_mentions,
-            as_user: false,
-            icon_url: gandhi_url
           )
         logger.warn("Slack response: #{response.pretty_inspect}") if logger
       end
     end
 
-    def gandhi_url
-      "https://vignette.wikia.nocookie.net/civilization/images/3/36/Gandhi_%28Civ5%29.png/revision/latest?cb=20121104232443"
-    end
-
     attr_reader :logger, :event_store
   end
 end

notifications/spec/notifications/slack_notifier_spec.rb

@@ -47,9 +47,7 @@ def given(*domain_events)
       stub = stub_request(:post, "https://slack.com/api/chat.postMessage")
         .with(
           body: {
-            "as_user" => "false",
             "channel" => "#arkency58",
-            "icon_url" => "https://vignette.wikia.nocookie.net/civilization/images/3/36/Gandhi_%28Civ5%29.png/revision/latest?cb=20121104232443",
             "text" => "Game  Turn 1 <!channel>\nsteam://run/8930/q/%2Bconnect%2010.4.0.28"
           },
           headers: {
@@ -71,9 +69,7 @@ def given(*domain_events)
       stub = stub_request(:post, "https://slack.com/api/chat.postMessage")
         .with(
           body: {
-            "as_user" => "false",
             "channel" => "#arkency58",
-            "icon_url" => "https://vignette.wikia.nocookie.net/civilization/images/3/36/Gandhi_%28Civ5%29.png/revision/latest?cb=20121104232443",
             "text" => "Turn <@slack_user>"
           },
           headers: {
@@ -116,9 +112,7 @@ def given(*domain_events)
       stub0 = stub_request(:post, "https://slack.com/api/chat.postMessage")
         .with(
           body: {
-            "as_user" => "false",
             "channel" => "#arkency58",
-            "icon_url" => "https://vignette.wikia.nocookie.net/civilization/images/3/36/Gandhi_%28Civ5%29.png/revision/latest?cb=20121104232443",
             "text" => "Turn <@slack_user> <@some_hidden_identifier>"
           },
           headers: {
@@ -133,9 +127,7 @@ def given(*domain_events)
       stub1 = stub_request(:post, "https://slack.com/api/chat.postMessage")
         .with(
           body: {
-            "as_user" => "false",
             "channel" => "#arkency58",
-            "icon_url" => "https://vignette.wikia.nocookie.net/civilization/images/3/36/Gandhi_%28Civ5%29.png/revision/latest?cb=20121104232443",
             "text" => "Turn <@slack_user>"
           },
           headers: {