Skip to content

Commit 185c8cd

Browse files
committed
don't use inheritance with Data.define
* it introduces an unnecessary anonymous class * mutant adds unwanted mutations in intializer
1 parent 63b909d commit 185c8cd

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

ecommerce/processes/lib/processes/reservation_process.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ def initialize(unavailable_products)
88
end
99
end
1010

11-
class ProcessState < Data.define(:order, :order_lines)
12-
def initialize(order: nil, order_lines: nil) = super
11+
ProcessState = Data.define(:order, :order_lines) do
12+
def initialize(order: nil, order_lines: [])
13+
super(order:, order_lines: order_lines.freeze)
14+
end
1315

1416
def reserved_product_ids = order_lines.keys
1517
end

ecommerce/processes/lib/processes/shipment_process.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module Processes
22
class ShipmentProcess
3-
class ProcessState < Data.define(:order, :shipment)
3+
ProcessState = Data.define(:order, :shipment) do
44
def initialize(order: nil, shipment: nil) = super
55
end
66

0 commit comments

Comments
 (0)