Skip to content

Commit 20345cb

Browse files
Remove Redis from the app
- removed from docker - removed from .env files - removed from Gemfile - removed from Github CI config - removed from README It was no longer needed and it did introduce addtional burden (recent heroku changes broke the app). Once we find a good need for Redis again, we will reintroduce it.
1 parent 7d36a44 commit 20345cb

File tree

7 files changed

+6
-33
lines changed

7 files changed

+6
-33
lines changed

.github/workflows/rails_application.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ jobs:
1010
fail-fast: false
1111
env:
1212
WORKING_DIRECTORY: rails_application
13-
REDIS_TLS_URL: redis://localhost:6379/0
1413
services:
1514
postgres_11:
1615
image: postgres:11
@@ -20,10 +19,6 @@ jobs:
2019
ports:
2120
- 5432:5432
2221
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
23-
redis:
24-
image: redis
25-
ports: [ "6379:6379" ]
26-
options: --entrypoint redis-server
2722
steps:
2823
- uses: actions/checkout@v3
2924
- uses: ruby/setup-ruby@v1
@@ -57,7 +52,6 @@ jobs:
5752
strategy:
5853
fail-fast: false
5954
env:
60-
REDIS_TLS_URL: redis://localhost:6379/0
6155
WORKING_DIRECTORY: rails_application
6256
services:
6357
postgres_11:
@@ -68,10 +62,6 @@ jobs:
6862
ports:
6963
- 5432:5432
7064
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
71-
redis:
72-
image: redis
73-
ports: [ "6379:6379" ]
74-
options: --entrypoint redis-server
7565
steps:
7666
- uses: actions/checkout@v3
7767
- uses: ruby/setup-ruby@v1

rails_application/.env.development

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
REDIS_URL=redis://localhost:6379/0
21
DATABASE_URL=postgres://postgres:secret@localhost/cqrs-es-sample-with-res_development

rails_application/.env.test

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
REDIS_URL=redis://localhost:6379/0
21
DATABASE_URL=postgres://postgres:secret@localhost/cqrs-es-sample-with-res_test

rails_application/Gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ gem "stimulus-rails"
1616
gem "importmap-rails", "~> 1.1"
1717
gem "rails_event_store", ">= 2.15.0", "< 3.0"
1818
gem 'arbre'
19-
gem 'redis', '~> 5.0'
2019

2120
group :development do
2221
gem "listen", "~> 3.3"

rails_application/Gemfile.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,6 @@ GEM
263263
ffi (~> 1.0)
264264
rdoc (6.7.0)
265265
psych (>= 4.0.0)
266-
redis (5.3.0)
267-
redis-client (>= 0.22.0)
268-
redis-client (0.22.2)
269-
connection_pool
270266
regexp_parser (2.9.2)
271267
reline (0.5.9)
272268
io-console (~> 0.5)
@@ -346,7 +342,6 @@ DEPENDENCIES
346342
puma (~> 5.6)
347343
rails (= 7.2.0)
348344
rails_event_store (>= 2.15.0, < 3.0)
349-
redis (~> 5.0)
350345
skylight
351346
sprockets-rails
352347
stimulus-rails

rails_application/README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,35 +4,33 @@
44

55
## Setup
66

7-
### Postgresql and Redis
7+
### Postgresql
88

99
#### Docker
1010

11-
If you would like to use Docker image with PostgreSQL and Redis provided by us,
11+
If you would like to use Docker image with PostgreSQL provided by us,
1212
run `docker-compose up -d`. You're done for this step.
1313

1414
#### Installed in the system
1515

16-
If you have PostgreSQL or Redis installed directly in your system and prefer
17-
to use them, create
16+
If you have PostgreSQL installed directly in your system and prefer
17+
to use it, create
1818

1919
- `.env.development.local`
2020
containing:
2121

2222
```
2323
DATABASE_URL=postgresql:///ecommerce_development
24-
REDIS_URL=redis://localhost:6379/1
2524
```
2625

2726
* `.env.test.local` containing:
2827

2928
```
3029
DATABASE_URL=postgresql:///ecommerce_test
31-
REDIS_URL=redis://localhost:6379/1
3230
```
3331

3432
It should would work for most of the cases. If you have more sophisticated setup,
35-
you need to update `DATABASE_URL` and `REDIS_URL` accordingly.
33+
you need to update `DATABASE_URL`.
3634

3735
### Kickstart
3836

rails_application/docker-compose.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,4 @@ services:
99
- POSTGRES_DB=cqrs-es-sample-with-res
1010
- POSTGRES_PASSWORD=secret
1111
ports:
12-
- "5432:5432"
13-
redis:
14-
image: 'bitnami/redis:latest'
15-
restart: always
16-
environment:
17-
- ALLOW_EMPTY_PASSWORD=yes
18-
ports:
19-
- "6379:6379"
12+
- "5432:5432"

0 commit comments

Comments
 (0)