Skip to content

Commit 3919ccb

Browse files
committed
Update and rename ordering tests after renaming refund to return.
1 parent 4e8ed8c commit 3919ccb

File tree

5 files changed

+59
-59
lines changed

5 files changed

+59
-59
lines changed

ecommerce/ordering/test/add_item_to_refund_test.rb renamed to ecommerce/ordering/test/add_item_to_return_test.rb

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
require_relative "test_helper"
22

33
module Ordering
4-
class AddItemToRefundTest < Test
5-
cover "Ordering::OnAddItemToRefund*"
4+
class AddItemToReturnTest < Test
5+
cover "Ordering::OnAddItemToReturn*"
66

7-
def test_add_item_to_refund
7+
def test_add_item_to_return
88
order_id = SecureRandom.uuid
99
aggregate_id = SecureRandom.uuid
1010
product_1_id = SecureRandom.uuid
1111
product_2_id = SecureRandom.uuid
1212
product_3_id = SecureRandom.uuid
13-
stream = "Ordering::Refund$#{aggregate_id}"
13+
stream = "Ordering::Return$#{aggregate_id}"
1414

1515
arrange(
1616
Pricing::SetPrice.new(product_id: product_1_id, price: 11),
@@ -22,18 +22,18 @@ def test_add_item_to_refund
2222
Pricing::AddPriceItem.new(order_id: order_id, product_id: product_3_id, price: 33),
2323
Pricing::AcceptOffer.new(order_id: order_id),
2424
Fulfillment::RegisterOrder.new(order_id: order_id),
25-
CreateDraftRefund.new(refund_id: aggregate_id, order_id: order_id),
26-
AddItemToRefund.new(
27-
refund_id: aggregate_id,
25+
CreateDraftReturn.new(return_id: aggregate_id, order_id: order_id),
26+
AddItemToReturn.new(
27+
return_id: aggregate_id,
2828
order_id: order_id,
2929
product_id: product_2_id
3030
)
3131
)
3232

3333
expected_events = [
34-
ItemAddedToRefund.new(
34+
ItemAddedToReturn.new(
3535
data: {
36-
refund_id: aggregate_id,
36+
return_id: aggregate_id,
3737
order_id: order_id,
3838
product_id: product_2_id
3939
}
@@ -42,8 +42,8 @@ def test_add_item_to_refund
4242

4343
assert_events(stream, *expected_events) do
4444
act(
45-
AddItemToRefund.new(
46-
refund_id: aggregate_id,
45+
AddItemToReturn.new(
46+
return_id: aggregate_id,
4747
order_id: order_id,
4848
product_id: product_2_id
4949
)
@@ -61,16 +61,16 @@ def test_add_item_raises_exceeds_order_quantity_error
6161
Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: 11),
6262
Pricing::AcceptOffer.new(order_id: order_id),
6363
Fulfillment::RegisterOrder.new(order_id: order_id),
64-
CreateDraftRefund.new(refund_id: aggregate_id, order_id: order_id),
65-
AddItemToRefund.new(
66-
refund_id: aggregate_id,
64+
CreateDraftReturn.new(return_id: aggregate_id, order_id: order_id),
65+
AddItemToReturn.new(
66+
return_id: aggregate_id,
6767
order_id: order_id,
6868
product_id: product_id
6969
)
7070
)
7171

72-
assert_raises(Ordering::Refund::ExceedsOrderQuantityError) do
73-
act(AddItemToRefund.new(refund_id: aggregate_id, order_id: order_id, product_id: product_id))
72+
assert_raises(Ordering::Return::ExceedsOrderQuantityError) do
73+
act(AddItemToReturn.new(return_id: aggregate_id, order_id: order_id, product_id: product_id))
7474
end
7575
end
7676
end

ecommerce/ordering/test/create_draft_refund_test.rb renamed to ecommerce/ordering/test/create_draft_return_test.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
require_relative "test_helper"
22

33
module Ordering
4-
class CreateDraftRefundTest < Test
5-
cover "Ordering::OnCreateDraftRefund*"
4+
class CreateDraftReturnTest < Test
5+
cover "Ordering::OnCreateDraftReturn*"
66

7-
def test_draft_refund_created
7+
def test_draft_return_created
88
order_id = SecureRandom.uuid
99
aggregate_id = SecureRandom.uuid
1010
product_id = SecureRandom.uuid
11-
stream = "Ordering::Refund$#{aggregate_id}"
11+
stream = "Ordering::Return$#{aggregate_id}"
1212

1313
arrange(
1414
Pricing::SetPrice.new(product_id: product_id, price: 11),
@@ -19,19 +19,19 @@ def test_draft_refund_created
1919
)
2020

2121
expected_events = [
22-
DraftRefundCreated.new(
22+
DraftReturnCreated.new(
2323
data: {
24-
refund_id: aggregate_id,
24+
return_id: aggregate_id,
2525
order_id: order_id,
26-
refundable_products: [{ product_id:, quantity: 2 }]
26+
returnable_products: [{ product_id:, quantity: 2 }]
2727
}
2828
)
2929
]
3030

3131
assert_events(stream, *expected_events) do
3232
act(
33-
CreateDraftRefund.new(
34-
refund_id: aggregate_id,
33+
CreateDraftReturn.new(
34+
return_id: aggregate_id,
3535
order_id: order_id
3636
)
3737
)

ecommerce/ordering/test/remove_item_from_refund_test.rb renamed to ecommerce/ordering/test/remove_item_from_return_test.rb

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
require_relative "test_helper"
22

33
module Ordering
4-
class RemoveItemFromRefundTest < Test
5-
cover "Ordering::OnRemoveItemFromRefund*"
4+
class RemoveItemFromReturnTest < Test
5+
cover "Ordering::OnRemoveItemFromReturn*"
66

7-
def test_removing_items_from_refund
7+
def test_removing_items_from_return
88
order_id = SecureRandom.uuid
99
aggregate_id = SecureRandom.uuid
1010
product_1_id = SecureRandom.uuid
1111
product_2_id = SecureRandom.uuid
1212
product_3_id = SecureRandom.uuid
13-
stream = "Ordering::Refund$#{aggregate_id}"
13+
stream = "Ordering::Return$#{aggregate_id}"
1414

1515
arrange(
1616
Pricing::SetPrice.new(product_id: product_1_id, price: 11),
@@ -22,21 +22,21 @@ def test_removing_items_from_refund
2222
Pricing::AddPriceItem.new(order_id: order_id, product_id: product_3_id, price: 33),
2323
Pricing::AcceptOffer.new(order_id: order_id),
2424
Fulfillment::RegisterOrder.new(order_id: order_id),
25-
CreateDraftRefund.new(
26-
refund_id: aggregate_id,
25+
CreateDraftReturn.new(
26+
return_id: aggregate_id,
2727
order_id: order_id
2828
),
29-
AddItemToRefund.new(
30-
refund_id: aggregate_id,
29+
AddItemToReturn.new(
30+
return_id: aggregate_id,
3131
order_id: order_id,
3232
product_id: product_1_id
3333
)
3434
)
3535

3636
expected_events = [
37-
ItemRemovedFromRefund.new(
37+
ItemRemovedFromReturn.new(
3838
data: {
39-
refund_id: aggregate_id,
39+
return_id: aggregate_id,
4040
order_id: order_id,
4141
product_id: product_1_id
4242
}
@@ -45,8 +45,8 @@ def test_removing_items_from_refund
4545

4646
assert_events(stream, *expected_events) do
4747
act(
48-
RemoveItemFromRefund.new(
49-
refund_id: aggregate_id,
48+
RemoveItemFromReturn.new(
49+
return_id: aggregate_id,
5050
order_id: order_id,
5151
product_id: product_1_id
5252
)
@@ -64,26 +64,26 @@ def test_cant_remove_item_with_0_quantity
6464
Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: 11),
6565
Pricing::AcceptOffer.new(order_id: order_id),
6666
Fulfillment::RegisterOrder.new(order_id: order_id),
67-
CreateDraftRefund.new(
68-
refund_id: aggregate_id,
67+
CreateDraftReturn.new(
68+
return_id: aggregate_id,
6969
order_id: order_id
7070
),
71-
AddItemToRefund.new(
72-
refund_id: aggregate_id,
71+
AddItemToReturn.new(
72+
return_id: aggregate_id,
7373
order_id: order_id,
7474
product_id: product_id
7575
),
76-
RemoveItemFromRefund.new(
77-
refund_id: aggregate_id,
76+
RemoveItemFromReturn.new(
77+
return_id: aggregate_id,
7878
order_id: order_id,
7979
product_id: product_id
8080
)
8181
)
8282

83-
assert_raises(Refund::RefundHaveNotBeenRequestedForThisProductError) do
83+
assert_raises(Return::ReturnHaveNotBeenRequestedForThisProductError) do
8484
act(
85-
RemoveItemFromRefund.new(
86-
refund_id: aggregate_id,
85+
RemoveItemFromReturn.new(
86+
return_id: aggregate_id,
8787
order_id: order_id,
8888
product_id: product_id
8989
)
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
require_relative "test_helper"
22

33
module Ordering
4-
class RefundItemsListTest < Test
4+
class ReturnItemsListTest < Test
55

66
def test_initialize
77
list = ItemsList.new
88

9-
assert_equal 0, list.refund_items.size
9+
assert_equal 0, list.return_items.size
1010
end
1111

1212
def test_increase_item_quantity
@@ -16,12 +16,12 @@ def test_increase_item_quantity
1616

1717
list.increase_quantity(product_one_id)
1818

19-
assert_equal 1, list.refund_items.size
19+
assert_equal 1, list.return_items.size
2020
assert_equal 1, list.quantity(product_one_id)
2121

2222
list.increase_quantity(product_two_id)
2323

24-
assert_equal 2, list.refund_items.size
24+
assert_equal 2, list.return_items.size
2525
assert_equal 1, list.quantity(product_two_id)
2626
end
2727

@@ -32,17 +32,17 @@ def test_decrease_item_quantity
3232
list.increase_quantity(product_id)
3333
list.increase_quantity(product_id)
3434

35-
assert_equal 1, list.refund_items.size
35+
assert_equal 1, list.return_items.size
3636
assert_equal 2, list.quantity(product_id)
3737

3838
list.decrease_quantity(product_id)
3939

40-
assert_equal 1, list.refund_items.size
40+
assert_equal 1, list.return_items.size
4141
assert_equal 1, list.quantity(product_id)
4242

4343
list.decrease_quantity(product_id)
4444

45-
assert_equal 0, list.refund_items.size
45+
assert_equal 0, list.return_items.size
4646
end
4747
end
4848
end

ecommerce/ordering/test/refundable_products_test.rb renamed to ecommerce/ordering/test/returnable_products_test.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
require_relative "test_helper"
22

33
module Ordering
4-
class RefundableProductsTest < Test
5-
cover "Ordering::RefundableProducts"
4+
class ReturnableProductsTest < Test
5+
cover "Ordering::ReturnableProducts"
66

7-
def test_product_quantity_available_to_refund
7+
def test_product_quantity_available_to_return
88
order_id = SecureRandom.uuid
99
order_number = Fulfillment::FakeNumberGenerator::FAKE_NUMBER
1010
product_1_id = SecureRandom.uuid
@@ -42,9 +42,9 @@ def test_product_quantity_available_to_refund
4242
stream_name: "Fulfillment::Order$#{order_id}"
4343
)
4444

45-
refundable_products = RefundableProducts.new.call(event_store, order_id)
45+
returnable_products = ReturnableProducts.new.call(event_store, order_id)
4646

47-
assert_equal([{ product_id: product_1_id, quantity: 1 }, { product_id: product_2_id, quantity: 1 }], refundable_products)
47+
assert_equal([{ product_id: product_1_id, quantity: 1 }, { product_id: product_2_id, quantity: 1 }], returnable_products)
4848
end
4949

5050
def test_order_have_to_be_placed
@@ -66,7 +66,7 @@ def test_order_have_to_be_placed
6666
],
6767
stream_name: stream_name)
6868

69-
assert_nil(RefundableProducts.new.call(event_store, order_id))
69+
assert_nil(ReturnableProducts.new.call(event_store, order_id))
7070
end
7171
end
7272
end

0 commit comments

Comments
 (0)