CR remarks

Author: marlena-b

ecommerce/ordering/lib/ordering.rb

@@ -22,7 +22,7 @@
 require_relative "ordering/service"
 require_relative "ordering/order"
 require_relative "ordering/refund"
-require_relative "ordering/projections"
+require_relative "ordering/product_quantity_available_to_refund"
 
 module Ordering
   class Configuration

…rce/ordering/lib/ordering/projections.rb …/product_quantity_available_to_refund.rbecommerce/ordering/lib/ordering/projections.rb renamed to ecommerce/ordering/lib/ordering/product_quantity_available_to_refund.rb ecommerce/ordering/lib/ordering/projections.rb renamed to ecommerce/ordering/lib/ordering/product_quantity_available_to_refund.rb

@@ -1,6 +1,6 @@
 module Ordering
-  class Projections
-    def self.product_quantity_available_to_refund(order_id, product_id)
+  class ProductQuantityAvailableToRefund
+    def self.call(order_id, product_id)
       RubyEventStore::Projection
         .from_stream("Ordering::Order$#{order_id}")
         .init(-> { { available: 0 } })

ecommerce/ordering/lib/ordering/refund.rb

@@ -3,7 +3,7 @@ class Refund
     include AggregateRoot
 
     ExceedsOrderQuantityError = Class.new(StandardError)
-    ProductNotFoundError = Class.new(StandardError)
+    RefundHaveNotBeenRequestedForThisProductError = Class.new(StandardError)
 
     def initialize(id)
       @id = id
@@ -20,7 +20,7 @@ def add_item(product_id, available_quantity_to_refund)
     end
 
     def remove_item(product_id)
-      raise ProductNotFoundError unless @refund_items.quantity(product_id).positive?
+      raise RefundHaveNotBeenRequestedForThisProductError unless @refund_items.quantity(product_id).positive?
       apply ItemRemovedFromRefund.new(data: { refund_id: @id, order_id: @order_id, product_id: product_id })
     end
 

ecommerce/ordering/lib/ordering/service.rb

@@ -103,8 +103,8 @@ def call(command)
     private
 
     def available_quantity_to_refund(order_id, product_id)
-      Projections
-        .product_quantity_available_to_refund(order_id, product_id)
+      ProductQuantityAvailableToRefund
+        .call(order_id, product_id)
         .run(@event_store)
         .fetch(:available)
     end

…mmerce/ordering/test/projections_test.rb …uct_quantity_available_to_refund_test.rbecommerce/ordering/test/projections_test.rb renamed to ecommerce/ordering/test/product_quantity_available_to_refund_test.rb ecommerce/ordering/test/projections_test.rb renamed to ecommerce/ordering/test/product_quantity_available_to_refund_test.rb

@@ -1,15 +1,15 @@
 require_relative "test_helper"
 
 module Ordering
-  class ProjectionsTest < Test
-    cover "Ordering::Projections"
+  class ProductQuantityAvailableToRefundTest < Test
+    cover "Ordering::ProductQuantityAvailableToRefund"
 
     def test_product_quantity_available_to_refund
       order_id = SecureRandom.uuid
       product_id = SecureRandom.uuid
       another_product_id = SecureRandom.uuid
       stream_name = "Ordering::Order$#{order_id}"
-      projection = Projections.product_quantity_available_to_refund(order_id, product_id)
+      projection = ProductQuantityAvailableToRefund.call(order_id, product_id)
 
       event_store = RubyEventStore::Client.new(repository: RubyEventStore::InMemoryRepository.new)
 

ecommerce/ordering/test/remove_item_from_refund_test.rb

@@ -67,7 +67,7 @@ def test_cant_remove_item_with_0_quantity
         )
       )
 
-      assert_raises(Refund::ProductNotFoundError) do
+      assert_raises(Refund::RefundHaveNotBeenRequestedForThisProductError) do
         act(
           RemoveItemFromRefund.new(
             refund_id: aggregate_id,

rails_application/app/controllers/refunds_controller.rb

@@ -23,7 +23,7 @@ def add_item
   def remove_item
     remove_item_from_refund
     redirect_to edit_order_refund_path(params[:id], order_id: params[:order_id])
-  rescue Ordering::Refund::ProductNotFoundError
+  rescue Ordering::Refund::RefundHaveNotBeenRequestedForThisProductError
     flash[:alert] = "This product is not added to the refund."
     redirect_to edit_order_refund_path(params[:id], order_id: params[:order_id])
   end