kill mutants

Author: porbas

ecommerce/pricing/lib/pricing/default_pricing_policy.rb

@@ -6,26 +6,33 @@ def initialize(pricing_catalog)
     end
 
     def apply(items, add_product_id = nil)
-      items
-      items += [catalog_price_for(add_product_id)] if add_product_id
-      items.map { |item| apply_discounts(item) }
+      ret = items.map do |item|
+        Offer::ItemPrice.new(
+          item.product_id,
+          item.catalog_price,
+          apply_discounts(item.catalog_price)
+        )
+      end
+      ret << Offer::ItemPrice.new(
+        add_product_id,
+        catalog_price_for(add_product_id),
+        apply_discounts(catalog_price_for(add_product_id))
+      ) if add_product_id
+      ret
     end
 
     def add_discount(discount)
       @discounts << discount
-      self
     end
 
     private
 
     def catalog_price_for(product_id)
-      price = @pricing_catalog.price_by_product_id(product_id)
-      Offer::ItemPrice.new(product_id, price, price)
+      @pricing_catalog.price_by_product_id(product_id)
     end
 
-    def apply_discounts(item)
-      price = @discounts.inject(Discounts::NoPercentageDiscount.new, :add).apply(item.catalog_price)
-      Offer::ItemPrice.new(item.product_id, item.catalog_price, price)
+    def apply_discounts(price)
+      @discounts.inject(Discounts::NoPercentageDiscount.new, :add).apply(price)
     end
   end
 end

ecommerce/pricing/lib/pricing/offer.rb

@@ -68,7 +68,7 @@ def remove_discount(type, pricing_policy)
           type: type
         }
       )
-      apply_discounts_to_pricing_policy(pricing_policy, except_type: type)
+      apply_discounts_to_pricing_policy(pricing_policy)
       recalculate_prices(pricing_policy)
     end
 
@@ -120,11 +120,8 @@ def use_coupon(coupon_id, discount)
 
     private
 
-    def apply_discounts_to_pricing_policy(pricing_policy, discount = nil, except_type: nil)
-      @discounts.each do |discount|
-        pricing_policy.add_discount(discount) unless discount.type == except_type
-      end
-      pricing_policy.add_discount(discount) if discount
+    def apply_discounts_to_pricing_policy(pricing_policy)
+      @discounts.each {|discount| pricing_policy.add_discount(discount) }
     end
 
     on PriceItemAdded do |event|
@@ -163,10 +160,6 @@ def apply_discounts_to_pricing_policy(pricing_policy, discount = nil, except_typ
       @list.replace(FreeProduct, Product, event.data.fetch(:product_id))
     end
 
-    def calculate_total_sub_discounts(pricing_catalog)
-      @list.sub_discounts(pricing_catalog, @discounts)
-    end
-
     on CouponUsed do |event|
     end
 

ecommerce/pricing/lib/pricing/services.rb

@@ -46,14 +46,13 @@ def call(cmd)
   class ChangePercentageDiscountHandler
     def initialize(event_store)
       @repository = Infra::AggregateRootRepository.new(event_store)
-      @event_store = event_store
     end
 
     def call(cmd)
       @repository.with_aggregate(Offer, cmd.aggregate_id) do |order|
         order.change_discount(
           Discounts::PercentageDiscount.new(cmd.amount),
-          DefaultPricingPolicy.new(PricingCatalog.new(@event_store))
+          DefaultPricingPolicy.new(nil)
         )
       end
     end