Revert "Three plus one gratis alternative implementation"

This reverts commit 41f02bd.

Author: lukaszreszke

ecommerce/pricing/lib/pricing/discounts.rb

@@ -6,9 +6,6 @@ module Discounts
     class UnacceptableDiscountRange < StandardError
     end
 
-    class BasePriceNotProvided < StandardError
-    end
-
     class Discount
       def self.build(discount)
         if discount.zero?
@@ -63,16 +60,5 @@ def add(other_discount)
       def exists?
       end
     end
-
-    class ThreePlusOneGratis
-      def apply(product_quantities, product_id, base_price)
-        raise BasePriceNotProvided unless base_price
-        product = product_quantities.find { |product_quantity| product_quantity.fetch(:product_id) == product_id }
-        return [false, base_price] if product.nil?
-        quantity = product.fetch(:quantity) + 1
-        return [false, base_price] if !quantity.%(4).eql?(0)
-        [true, 0]
-      end
-    end
   end
 end

ecommerce/pricing/lib/pricing/events.rb

@@ -56,12 +56,6 @@ class PriceItemRemoved < Infra::Event
     attribute :total_value, Infra::Types::Price
   end
 
-  class DiscountApplied < Infra::Event
-    attribute :order_id, Infra::Types::UUID
-    attribute :base_total_value, Infra::Types::Price
-    attribute :total_value, Infra::Types::Price
-  end
-
   class PercentageDiscountRemoved < Infra::Event
     attribute :order_id, Infra::Types::UUID
     attribute :type, Infra::Types::String

ecommerce/pricing/lib/pricing/offer.rb

@@ -10,8 +10,6 @@ def initialize(id)
       @list = List.new
       @discounts = []
       @state = :draft
-
-      @three_plus_one_gratis = Discounts::ThreePlusOneGratis.new(@list)
     end
 
     def add_item(product_id, base_price)
@@ -26,15 +24,6 @@ def add_item(product_id, base_price)
           total_value: @list.actual_sum + price
         }
       )
-      
-      anything_applied = @three_plus_one_gratis.apply(base_price)
-      apply DiscountApplied.new(
-        data: {
-          order_id: @id,
-          base_total_value: @list.base_sum,
-          total_value: @list.actual_sum
-        }
-      ) if anything_applied
     end
 
     def remove_item(product_id)
@@ -173,10 +162,6 @@ def expire
 
     private
 
-    on DiscountApplied do |event|
-      # TODO: Something about discount?
-    end
-
     on PriceItemAdded do |event|
       @list.add_item(event.data.fetch(:product_id), event.data.fetch(:base_price), event.data.fetch(:price))
     end

ecommerce/pricing/test/discounts_test.rb

@@ -64,61 +64,5 @@ def test_doesnt_change_total
         assert_equal(100, NoPercentageDiscount.new.apply(100))
       end
     end
-    class ThreePlusOneGratisTest < Test
-      cover "Pricing::Discounts*"
-      def setup
-        @three_plus_one_gratis = ThreePlusOneGratis.new
-        @product_id = SecureRandom.uuid
-      end
-
-      def test_returns_full_price_when_product_not_found
-        result = @three_plus_one_gratis.apply([], @product_id, 20)
-        assert_equal [false, 20], result
-      end
-
-      def test_returns_full_price_when_quantity_plus_one_is_less_than_4
-        quantities = [{ product_id: @product_id, quantity: 2 }]
-        result = @three_plus_one_gratis.apply(quantities, @product_id, 20)
-        assert_equal [false, 20], result
-      end
-
-      def test_returns_free_when_quantity_plus_one_is_4
-        quantities = [{ product_id: @product_id, quantity: 3 }]
-        result = @three_plus_one_gratis.apply(quantities, @product_id, 20)
-        assert_equal [true, 0], result
-      end
-
-      def test_returns_full_price_when_quantity_plus_one_is_5
-        quantities = [{ product_id: @product_id, quantity: 4 }]
-        result = @three_plus_one_gratis.apply(quantities, @product_id, 20)
-        assert_equal [false, 20], result
-      end
-
-      def test_returns_free_when_quantity_plus_one_is_8
-        quantities = [{ product_id: @product_id, quantity: 7 }]
-        result = @three_plus_one_gratis.apply(quantities, @product_id, 20)
-        assert_equal [true, 0], result
-      end
-
-      def test_returns_full_price_when_quantity_plus_one_is_9
-        quantities = [{ product_id: @product_id, quantity: 8 }]
-        result = @three_plus_one_gratis.apply(quantities, @product_id, 20)
-        assert_equal [false, 20], result
-      end
-
-      def test_does_not_confuse_other_product_ids
-        other_product_id = SecureRandom.uuid
-        quantities = [{ product_id: other_product_id, quantity: 3 }]
-        result = @three_plus_one_gratis.apply(quantities, @product_id, 20)
-        assert_equal [false, 20], result
-      end
-
-      def test_raises_exeption_when_base_price_is_nil
-        quantities = [{ product_id: @product_id, quantity: 8 }]
-        assert_raises BasePriceNotProvided do
-          @three_plus_one_gratis.apply(quantities, @product_id, nil)
-        end
-      end
-    end
   end
 end