Fix rails_application tests after adding price to pricing command/events

porbas · porbas · commit 67226db16c13 · 2025-04-03T10:52:47.000+02:00
diff --git a/rails_application/test/client_orders/discount_test.rb b/rails_application/test/client_orders/discount_test.rb
@@ -86,7 +86,7 @@ def change_percentage_discount(order_id)
     end
 
     def item_added_to_basket(order_id, product_id)
-      run_command(Pricing::AddPriceItem.new(product_id: product_id, order_id: order_id))
+      run_command(Pricing::AddPriceItem.new(product_id: product_id, order_id: order_id, price: 50))
     end
 
     def prepare_product(product_id)
diff --git a/rails_application/test/client_orders/item_added_to_basket_test.rb b/rails_application/test/client_orders/item_added_to_basket_test.rb
@@ -28,6 +28,7 @@ def test_add_new_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 49,
           }
         )
       )
@@ -70,6 +71,7 @@ def test_add_the_same_item_2nd_time
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 49,
           }
         )
       )
@@ -79,6 +81,7 @@ def test_add_the_same_item_2nd_time
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 49,
           }
         )
       )
@@ -137,6 +140,7 @@ def test_add_another_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -146,6 +150,7 @@ def test_add_another_item
           data: {
             order_id: order_id,
             product_id: another_product_id,
+            price: 20,
           }
         )
       )
diff --git a/rails_application/test/client_orders/item_removed_from_basket_test.rb b/rails_application/test/client_orders/item_removed_from_basket_test.rb
@@ -30,6 +30,7 @@ def test_remove_item_when_quantity_gt_1
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -38,6 +39,7 @@ def test_remove_item_when_quantity_gt_1
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -83,6 +85,7 @@ def test_remove_item_when_quantity_eq_1
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -140,6 +143,7 @@ def test_remove_item_when_there_is_another_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -148,6 +152,7 @@ def test_remove_item_when_there_is_another_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -156,6 +161,7 @@ def test_remove_item_when_there_is_another_item
           data: {
             order_id: order_id,
             product_id: another_product_id,
+            price: 20,
           }
         )
       )
diff --git a/rails_application/test/client_orders/order_cancelled_test.rb b/rails_application/test/client_orders/order_cancelled_test.rb
@@ -18,7 +18,7 @@ def test_order_confirmed
       ))
 
       create_product(product_id, "Async Remote", 30)
-      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: 30))
       run_command(Pricing::AcceptOffer.new(order_id: order_id))
 
       event_store.publish(
diff --git a/rails_application/test/client_orders/order_expired_test.rb b/rails_application/test/client_orders/order_expired_test.rb
@@ -34,6 +34,7 @@ def test_order_expired
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 39
           }
         )
       )
diff --git a/rails_application/test/client_orders/order_paid_test.rb b/rails_application/test/client_orders/order_paid_test.rb
@@ -12,7 +12,7 @@ def test_order_confirmed
 
       run_command(Crm::RegisterCustomer.new(customer_id: customer_id, name: "John Doe"))
       create_product(product_id, "Async Remote", 30)
-      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: 30))
 
       event_store.publish(
         Pricing::OrderTotalValueCalculated.new(
diff --git a/rails_application/test/client_orders/time_promotion_discount_test.rb b/rails_application/test/client_orders/time_promotion_discount_test.rb
@@ -60,7 +60,7 @@ def set_percentage_discount(order_id)
     end
 
     def item_added_to_basket(order_id, product_id)
-      run_command(Pricing::AddPriceItem.new(product_id: product_id, order_id: order_id))
+      run_command(Pricing::AddPriceItem.new(product_id: product_id, order_id: order_id, price: 50))
     end
 
     def prepare_product(product_id)
diff --git a/rails_application/test/client_orders/update_paid_orders_summary_test.rb b/rails_application/test/client_orders/update_paid_orders_summary_test.rb
@@ -15,15 +15,15 @@ def test_update_orders_summary
       set_price_to_product(product_id, 3)
       register_customer(other_customer_id)
       register_customer(customer_id)
-      add_item_to_basket(order_id, product_id)
+      add_item_to_basket(order_id, product_id, 3)
       confirm_order(customer_id, order_id, 3)
 
       customer = Client.find_by(uid: customer_id)
       assert_equal 3.to_d, customer.paid_orders_summary
 
       order_id = SecureRandom.uuid
-      add_item_to_basket(order_id, product_id)
-      add_item_to_basket(order_id, product_id)
+      add_item_to_basket(order_id, product_id, 3)
+      add_item_to_basket(order_id, product_id, 3)
       confirm_order(customer_id, order_id, 6)
 
       customer = Client.find_by(uid: customer_id)
@@ -53,8 +53,8 @@ def set_price_to_product(product_id, price)
       run_command(Pricing::SetPrice.new(product_id: product_id, price: price))
     end
 
-    def add_item_to_basket(order_id, product_id)
-      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+    def add_item_to_basket(order_id, product_id, price)
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: price))
     end
 
     def confirm_order(customer_id, order_id, total_amount)
diff --git a/rails_application/test/customers/update_paid_orders_summary_test.rb b/rails_application/test/customers/update_paid_orders_summary_test.rb
@@ -15,15 +15,15 @@ def test_update_orders_summary
       register_product(product_id)
       name_product(product_id, "Async Remote")
       set_price_to_product(product_id, 3)
-      add_item_to_basket(order_id, product_id)
+      add_item_to_basket(order_id, product_id, 3)
       confirm_order(customer_id, order_id, 3)
 
       customer = Customer.find(customer_id)
       assert_equal 3.to_d, customer.paid_orders_summary
 
       order_id = SecureRandom.uuid
-      add_item_to_basket(order_id, product_id)
-      add_item_to_basket(order_id, product_id)
+      add_item_to_basket(order_id, product_id, 3)
+      add_item_to_basket(order_id, product_id, 3)
       confirm_order(customer_id, order_id, 6)
 
       customer = Customer.find(customer_id)
@@ -48,8 +48,8 @@ def set_price_to_product(product_id, price)
       run_command(Pricing::SetPrice.new(product_id: product_id, price: price))
     end
 
-    def add_item_to_basket(order_id, product_id)
-      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+    def add_item_to_basket(order_id, product_id, price)
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: price))
     end
 
     def confirm_order(customer_id, order_id, total_amount)
diff --git a/rails_application/test/orders/broadcast_test.rb b/rails_application/test/orders/broadcast_test.rb
@@ -50,6 +50,7 @@ def test_broadcast_add_item_to_basket
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -83,6 +84,7 @@ def test_broadcast_remove_item_from_basket
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -128,6 +130,7 @@ def test_broadcast_update_order_value
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -136,6 +139,7 @@ def test_broadcast_update_order_value
           data: {
             order_id: order_1_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -194,6 +198,7 @@ def test_broadcast_update_discount
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -202,6 +207,7 @@ def test_broadcast_update_discount
           data: {
             order_id: order_1_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
diff --git a/rails_application/test/orders/discount_test.rb b/rails_application/test/orders/discount_test.rb
@@ -121,7 +121,7 @@ def change_percentage_discount(order_id)
     end
 
     def item_added_to_basket(order_id, product_id)
-      run_command(Pricing::AddPriceItem.new(product_id: product_id, order_id: order_id ))
+      run_command(Pricing::AddPriceItem.new(product_id: product_id, order_id: order_id, price: 50))
     end
 
     def prepare_product(product_id)
diff --git a/rails_application/test/orders/item_added_to_basket_test.rb b/rails_application/test/orders/item_added_to_basket_test.rb
@@ -27,6 +27,7 @@ def test_add_new_item
         data: {
           order_id: order_id,
           product_id: product_id,
+          price: 49,
         }
       )
       event_store.publish(item_added_to_basket)
@@ -70,6 +71,7 @@ def test_add_the_same_item_2nd_time
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 49,
           }
         )
       )
@@ -79,6 +81,7 @@ def test_add_the_same_item_2nd_time
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 49,
           }
         )
       )
@@ -137,6 +140,7 @@ def test_add_another_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -146,6 +150,7 @@ def test_add_another_item
           data: {
             order_id: order_id,
             product_id: another_product_id,
+            price: 20,
           }
         )
       )
diff --git a/rails_application/test/orders/item_added_to_refund_test.rb b/rails_application/test/orders/item_added_to_refund_test.rb
@@ -9,7 +9,7 @@ def test_add_item_to_refund
       product_id = SecureRandom.uuid
       order_id = SecureRandom.uuid
       prepare_product(product_id, 50)
-      place_order(order_id, product_id)
+      place_order(order_id, product_id, 50)
       create_draft_refund(refund_id, order_id)
 
       AddItemToRefund.new.call(item_added_to_refund(refund_id, order_id, product_id))
@@ -42,8 +42,8 @@ def prepare_product(product_id, price)
       run_command(Pricing::SetPrice.new(product_id: product_id, price: price))
     end
 
-    def place_order(order_id, product_id)
-      run_command(Pricing::AddPriceItem.new(order_id:, product_id:))
+    def place_order(order_id, product_id, price)
+      run_command(Pricing::AddPriceItem.new(order_id:, product_id:, price:))
       run_command(Pricing::AcceptOffer.new(order_id:))
     end
 
diff --git a/rails_application/test/orders/item_removed_from_basket_test.rb b/rails_application/test/orders/item_removed_from_basket_test.rb
@@ -30,6 +30,7 @@ def test_remove_item_when_quantity_gt_1
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -38,6 +39,7 @@ def test_remove_item_when_quantity_gt_1
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -83,6 +85,7 @@ def test_remove_item_when_quantity_eq_1
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -140,6 +143,7 @@ def test_remove_item_when_there_is_another_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -148,6 +152,7 @@ def test_remove_item_when_there_is_another_item
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20,
           }
         )
       )
@@ -156,6 +161,7 @@ def test_remove_item_when_there_is_another_item
           data: {
             order_id: order_id,
             product_id: another_product_id,
+            price: 20,
           }
         )
       )
diff --git a/rails_application/test/orders/order_cancelled_test.rb b/rails_application/test/orders/order_cancelled_test.rb
@@ -19,7 +19,7 @@ def test_cancel_confirmed_order
       ))
 
       create_product(product_id, "Async Remote", 30)
-      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: 30))
       run_command(Pricing::AcceptOffer.new(order_id: order_id))
 
       order_cancelled = Fulfillment::OrderCancelled.new(
diff --git a/rails_application/test/orders/order_expired_test.rb b/rails_application/test/orders/order_expired_test.rb
@@ -31,6 +31,7 @@ def test_expire_created_order
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 39
           }
         )
       )
diff --git a/rails_application/test/orders/order_paid_test.rb b/rails_application/test/orders/order_paid_test.rb
@@ -13,7 +13,7 @@ def test_order_confirmed
 
       create_product(product_id, "Async Remote", 10)
       run_command(Crm::RegisterCustomer.new(customer_id: customer_id, name: "John Doe"))
-      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id, price: 10))
       run_command(Pricing::AcceptOffer.new(order_id: order_id))
       run_command(
         Crm::AssignCustomerToOrder.new(customer_id: customer_id, order_id: order_id)
diff --git a/rails_application/test/orders/order_placed_test.rb b/rails_application/test/orders/order_placed_test.rb
@@ -29,6 +29,7 @@ def test_create_when_not_exists
           data: {
             order_id: order_id,
             product_id: product_id,
+            price: 20
           }
         ),
         Pricing::OfferAccepted.new(
diff --git a/rails_application/test/orders/remove_time_promotion_discount_test.rb b/rails_application/test/orders/remove_time_promotion_discount_test.rb
@@ -38,7 +38,7 @@ def test_does_not_removes_time_promotion_when_removing_general_discount
     private
 
     def item_added_to_basket(order_id, product_id)
-      event_store.publish(Pricing::PriceItemAdded.new(data: { product_id: product_id, order_id: order_id }))
+      event_store.publish(Pricing::PriceItemAdded.new(data: { product_id: product_id, order_id: order_id, price: 50 }))
     end
 
     def prepare_product(product_id)
diff --git a/rails_application/test/orders/update_order_total_value_test.rb b/rails_application/test/orders/update_order_total_value_test.rb
diff --git a/rails_application/test/orders/update_time_promotion_discount_value_test.rb b/rails_application/test/orders/update_time_promotion_discount_value_test.rb
diff --git a/rails_application/test/services/client/orders/submit_service_test.rb b/rails_application/test/services/client/orders/submit_service_test.rb
diff --git a/rails_application/test/services/orders/submit_service_test.rb b/rails_application/test/services/orders/submit_service_test.rb

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ def test_add_new_item`
`28`	`28`	`data: {`
`29`	`29`	`order_id: order_id,`
`30`	`30`	`product_id: product_id,`
	`31`	`+ price: 49,`
`31`	`32`	`}`
`32`	`33`	`)`
`33`	`34`	`)`
`@@ -70,6 +71,7 @@ def test_add_the_same_item_2nd_time`
`70`	`71`	`data: {`
`71`	`72`	`order_id: order_id,`
`72`	`73`	`product_id: product_id,`
	`74`	`+ price: 49,`
`73`	`75`	`}`
`74`	`76`	`)`
`75`	`77`	`)`
`@@ -79,6 +81,7 @@ def test_add_the_same_item_2nd_time`
`79`	`81`	`data: {`
`80`	`82`	`order_id: order_id,`
`81`	`83`	`product_id: product_id,`
	`84`	`+ price: 49,`
`82`	`85`	`}`
`83`	`86`	`)`
`84`	`87`	`)`
`@@ -137,6 +140,7 @@ def test_add_another_item`
`137`	`140`	`data: {`
`138`	`141`	`order_id: order_id,`
`139`	`142`	`product_id: product_id,`
	`143`	`+ price: 20,`
`140`	`144`	`}`
`141`	`145`	`)`
`142`	`146`	`)`
`@@ -146,6 +150,7 @@ def test_add_another_item`
`146`	`150`	`data: {`
`147`	`151`	`order_id: order_id,`
`148`	`152`	`product_id: another_product_id,`
	`153`	`+ price: 20,`
`149`	`154`	`}`
`150`	`155`	`)`
`151`	`156`	`)`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ def test_remove_item_when_quantity_gt_1`
`30`	`30`	`data: {`
`31`	`31`	`order_id: order_id,`
`32`	`32`	`product_id: product_id,`
	`33`	`+ price: 20,`
`33`	`34`	`}`
`34`	`35`	`)`
`35`	`36`	`)`
`@@ -38,6 +39,7 @@ def test_remove_item_when_quantity_gt_1`
`38`	`39`	`data: {`
`39`	`40`	`order_id: order_id,`
`40`	`41`	`product_id: product_id,`
	`42`	`+ price: 20,`
`41`	`43`	`}`
`42`	`44`	`)`
`43`	`45`	`)`
`@@ -83,6 +85,7 @@ def test_remove_item_when_quantity_eq_1`
`83`	`85`	`data: {`
`84`	`86`	`order_id: order_id,`
`85`	`87`	`product_id: product_id,`
	`88`	`+ price: 20,`
`86`	`89`	`}`
`87`	`90`	`)`
`88`	`91`	`)`
`@@ -140,6 +143,7 @@ def test_remove_item_when_there_is_another_item`
`140`	`143`	`data: {`
`141`	`144`	`order_id: order_id,`
`142`	`145`	`product_id: product_id,`
	`146`	`+ price: 20,`
`143`	`147`	`}`
`144`	`148`	`)`
`145`	`149`	`)`
`@@ -148,6 +152,7 @@ def test_remove_item_when_there_is_another_item`
`148`	`152`	`data: {`
`149`	`153`	`order_id: order_id,`
`150`	`154`	`product_id: product_id,`
	`155`	`+ price: 20,`
`151`	`156`	`}`
`152`	`157`	`)`
`153`	`158`	`)`
`@@ -156,6 +161,7 @@ def test_remove_item_when_there_is_another_item`
`156`	`161`	`data: {`
`157`	`162`	`order_id: order_id,`
`158`	`163`	`product_id: another_product_id,`
	`164`	`+ price: 20,`
`159`	`165`	`}`
`160`	`166`	`)`
`161`	`167`	`)`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ def test_order_expired`
`34`	`34`	`data: {`
`35`	`35`	`order_id: order_id,`
`36`	`36`	`product_id: product_id,`
	`37`	`+ price: 39`
`37`	`38`	`}`
`38`	`39`	`)`
`39`	`40`	`)`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ def test_broadcast_add_item_to_basket`
`50`	`50`	`data: {`
`51`	`51`	`order_id: order_id,`
`52`	`52`	`product_id: product_id,`
	`53`	`+ price: 20,`
`53`	`54`	`}`
`54`	`55`	`)`
`55`	`56`	`)`
`@@ -83,6 +84,7 @@ def test_broadcast_remove_item_from_basket`
`83`	`84`	`data: {`
`84`	`85`	`order_id: order_id,`
`85`	`86`	`product_id: product_id,`
	`87`	`+ price: 20,`
`86`	`88`	`}`
`87`	`89`	`)`
`88`	`90`	`)`
`@@ -128,6 +130,7 @@ def test_broadcast_update_order_value`
`128`	`130`	`data: {`
`129`	`131`	`order_id: order_id,`
`130`	`132`	`product_id: product_id,`
	`133`	`+ price: 20,`
`131`	`134`	`}`
`132`	`135`	`)`
`133`	`136`	`)`
`@@ -136,6 +139,7 @@ def test_broadcast_update_order_value`
`136`	`139`	`data: {`
`137`	`140`	`order_id: order_1_id,`
`138`	`141`	`product_id: product_id,`
	`142`	`+ price: 20,`
`139`	`143`	`}`
`140`	`144`	`)`
`141`	`145`	`)`
`@@ -194,6 +198,7 @@ def test_broadcast_update_discount`
`194`	`198`	`data: {`
`195`	`199`	`order_id: order_id,`
`196`	`200`	`product_id: product_id,`
	`201`	`+ price: 20,`
`197`	`202`	`}`
`198`	`203`	`)`
`199`	`204`	`)`
`@@ -202,6 +207,7 @@ def test_broadcast_update_discount`
`202`	`207`	`data: {`
`203`	`208`	`order_id: order_1_id,`
`204`	`209`	`product_id: product_id,`
	`210`	`+ price: 20,`
`205`	`211`	`}`
`206`	`212`	`)`
`207`	`213`	`)`