Improved VatRates coverage

Author: andrzejkrzywda

rails_application/db/schema.rb

@@ -165,6 +165,7 @@
     t.date "disposal_date"
     t.date "payment_date"
     t.decimal "total_value", precision: 8, scale: 2
+    t.uuid "store_id"
   end
 
   create_table "invoices_orders", force: :cascade do |t|

rails_application/test/integration/store_switching_test.rb

@@ -2,8 +2,8 @@
 
 class StoreSwitchingTest < InMemoryRESIntegrationTestCase
   def test_first_store_selected_by_default_when_no_cookie
-    store_1_id = register_store("Store A")
-    store_2_id = register_store("Store B")
+    register_store("Store A")
+    register_store("Store B")
 
     get products_path
 
@@ -12,7 +12,6 @@ def test_first_store_selected_by_default_when_no_cookie
   end
 
   def test_cookie_is_preserved_across_requests
-    store_1_id = register_store("Store A")
     store_2_id = register_store("Store B")
 
     get products_path
@@ -26,8 +25,8 @@ def test_cookie_is_preserved_across_requests
   end
 
   def test_fallback_to_first_store_when_cookie_points_to_nonexistent_store
-    store_1_id = register_store("Store A")
-    store_2_id = register_store("Store B")
+    register_store("Store A")
+    register_store("Store B")
     nonexistent_store_id = SecureRandom.uuid
 
     cookies[:current_store_id] = nonexistent_store_id
@@ -39,7 +38,6 @@ def test_fallback_to_first_store_when_cookie_points_to_nonexistent_store
   end
 
   def test_switching_stores_updates_cookie
-    store_1_id = register_store("Store A")
     store_2_id = register_store("Store B")
 
     get products_path

rails_application/test/vat_rates/assign_store_to_available_vat_rate_test.rb

@@ -25,5 +25,20 @@ def test_assign_store_to_existing_available_vat_rate
 
       assert_equal(store_id, AvailableVatRate.find_by!(uid: vat_rate_id).store_id)
     end
+
+    def test_assigns_store_to_correct_vat_rate_by_uid
+      event_store = Rails.configuration.event_store
+      store_id = SecureRandom.uuid
+      vat_rate_1_id = SecureRandom.uuid
+      vat_rate_2_id = SecureRandom.uuid
+
+      AvailableVatRate.create!(uid: vat_rate_1_id, code: "standard", rate: 20)
+      AvailableVatRate.create!(uid: vat_rate_2_id, code: "reduced", rate: 10)
+
+      event_store.publish(Stores::VatRateRegistered.new(data: { store_id: store_id, vat_rate_id: vat_rate_1_id }))
+
+      assert_equal(store_id, AvailableVatRate.find_by!(uid: vat_rate_1_id).store_id)
+      assert_nil(AvailableVatRate.find_by!(uid: vat_rate_2_id).store_id)
+    end
   end
 end

rails_application/test/vat_rates/remove_available_vat_rate_test.rb

@@ -0,0 +1,24 @@
+require "test_helper"
+
+module VatRates
+  class RemoveAvailableVatRateTest < InMemoryTestCase
+    cover "VatRates*"
+
+    def test_removing_available_vat_rate
+      uid = SecureRandom.uuid
+      code = "standard"
+      rate = 20
+
+      event_store.publish(Taxes::AvailableVatRateAdded.new(data: { available_vat_rate_id: uid, vat_rate: { code: code, rate: rate } }))
+      event_store.publish(Taxes::AvailableVatRateRemoved.new(data: { vat_rate_code: code }))
+
+      assert_nil(AvailableVatRate.find_by(code: code))
+    end
+
+    private
+
+    def event_store
+      Rails.configuration.event_store
+    end
+  end
+end