Skip to content

Commit aaac9bc

Browse files
committed
Improve readability of the super() call by omitting the list of kwargs.
- for Ruby 3.0+ the args will be passed by default - when args are transformed (for example in ReservationProcess order_lines array is frozen before they are passed to super) old logic remains
1 parent 1b4fa5a commit aaac9bc

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

ecommerce/processes/lib/processes/determine_vat_rates_on_order_placed.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ class DetermineVatRatesOnOrderPlaced
33

44
ProcessState = Data.define(:offer_accepted, :order_placed, :order_id, :order_lines) do
55
def initialize(offer_accepted: false, order_placed: false, order_id: nil, order_lines: [])
6-
super(offer_accepted:, order_placed:, order_id:, order_lines: order_lines)
6+
super
77
end
88

99
def placed? = offer_accepted && order_placed

ecommerce/processes/lib/processes/order_item_invoicing_process.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ class OrderItemInvoicingProcess
33

44
ProcessState = Data.define(:order_id, :product_id, :quantity, :vat_rate, :discounted_amount) do
55
def initialize(order_id: nil, product_id: nil, quantity: nil, vat_rate: nil, discounted_amount: nil)
6-
super(order_id:, product_id:, quantity:, vat_rate:, discounted_amount:)
6+
super
77
end
88

99
def can_create_invoice_item?

ecommerce/processes/lib/processes/release_payment_process.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ class ReleasePaymentProcess
33

44
ProcessState = Data.define(:order, :payment, :order_id) do
55
def initialize(order: :draft, payment: :none, order_id: nil)
6-
super(order:, payment:, order_id:)
6+
super
77
end
88

99
def release?

0 commit comments

Comments
 (0)