Extracted OrderHeaader read model from Orders

Orders was already too big. Also, there were clear "boxes" of data visually on the site. Which can be a heuristic to make it a new read model.

cleanups:
Shipments no longer rely on Orders::Order, they never should

Author: andrzejkrzywda

apps/rails_application/.mutant.yml

@@ -17,6 +17,7 @@ matcher:
   subjects:
     - Coupons*
     - Orders*
+    - OrderHeader*
     - ClientOrders*
     - Processes*
     - Invoices*
@@ -25,6 +26,8 @@ matcher:
   ignore:
     - Coupons::Configuration#call
     - Orders::Configuration#call
+    - Orders::Configuration#broadcast_order_state_change
+    - OrderHeader::Configuration#call
     - Invoices::Configuration#call
     - Orders::Broadcaster*
     - Orders::AddItemToOrder#broadcast_to_ui

apps/rails_application/app/controllers/orders_controller.rb

@@ -79,7 +79,7 @@ def remove_item
   end
 
   def create
-    Orders::SubmitService.call(order_id: params[:order_id], customer_id: params[:customer_id])
+    Orders::SubmitService.new(params[:order_id], params[:customer_id]).call
   rescue Orders::OrderHasUnavailableProducts => e
     unavailable_products = e.unavailable_products.join(", ")
     redirect_to edit_order_path(params[:order_id]), alert: "Order can not be submitted! #{unavailable_products} not available in requested quantity!"
@@ -92,7 +92,7 @@ def create
   end
 
   def expire
-    Orders.draft_orders.find_each { |order| command_bus.(Pricing::ExpireOffer.new(order_id: order.uid)) }
+    OrderHeader.draft_orders.find_each { |order| command_bus.(Pricing::ExpireOffer.new(order_id: order.uid)) }
     redirect_to root_path
   end
 

apps/rails_application/app/read_models/order_header/configuration.rb

@@ -6,7 +6,7 @@ class Header < ApplicationRecord
   private_constant :Header
 
   class Customer < ApplicationRecord
-    self.table_name = "orders_customers"
+    self.table_name = "order_header_customers"
   end
 
   private_constant :Customer
@@ -15,8 +15,13 @@ def self.find_by_uid(uid)
     Header.find_by_uid(uid)
   end
 
+  def self.draft_orders
+    Header.where(state: "Draft")
+  end
+
   class Configuration
     def call(event_store)
+      event_store.subscribe(CreateCustomer.new, to: [Crm::CustomerRegistered])
       event_store.subscribe(
         ->(event) { draft_order_header(event) },
         to: [Pricing::OfferDrafted]
@@ -70,7 +75,7 @@ def draft_order_header(event)
 
     def assign_customer(event)
       customer_id = event.data.fetch(:customer_id)
-      customer_name = Customer.find_by_uid(customer_id).name
+      customer_name = Customer.find_by(customer_id: customer_id).name
       find_or_create_header(event.data.fetch(:order_id)).update!(customer: customer_name)
     end
 

apps/rails_application/app/read_models/orders/add_item_to_order.rb

@@ -6,7 +6,7 @@ class AddItemToOrder
 
     def call(event)
       order_id = event.data.fetch(:order_id)
-      Order.find_or_create_by!(uid: order_id) { |order| order.state = "Draft" }
+      Order.find_or_create_by!(uid: order_id)
       product_id = event.data.fetch(:product_id)
       item =
         find(order_id, product_id) ||

apps/rails_application/app/read_models/orders/assign_customer_to_order.rb

@@ -2,9 +2,7 @@ module Orders
   class AssignCustomerToOrder
     def call(event)
       order_uid = event.data.fetch(:order_id)
-      order = Order.find_or_create_by!(uid: order_uid) { |order| order.state = "Draft" }
-      order.customer = Customer.find_by_uid(event.data.fetch(:customer_id)).name
-      order.save!
+      Order.find_or_create_by!(uid: order_uid)
 
       event_store.link_event_to_stream(event, "Orders$all")
     end

apps/rails_application/app/read_models/orders/cancel_order.rb

@@ -17,12 +17,6 @@ class Product < ApplicationRecord
 
   private_constant :Product
 
-  class Customer < ApplicationRecord
-    self.table_name = "orders_customers"
-  end
-
-  private_constant :Customer
-
   class OrderLine < ApplicationRecord
     self.table_name = "order_lines"
 
@@ -69,17 +63,14 @@ def self.store_id_for_order(order_id)
     Order.find_by!(uid: order_id).store_id
   end
 
-  def self.draft_orders
-    Order.where(state: "Draft")
-  end
-
   class Configuration
 
     def call(event_store)
       Rails.configuration.broadcaster = Orders::Broadcaster.new
 
       event_store.subscribe(DraftOrder.new, to: [Pricing::OfferDrafted])
       event_store.subscribe(AssignStoreToOrder.new, to: [Stores::OfferRegistered])
+      event_store.subscribe(AssignCustomerToOrder.new, to: [Crm::CustomerAssignedToOrder])
       event_store.subscribe(AddItemToOrder.new, to: [Pricing::PriceItemAdded])
       event_store.subscribe(RemoveItemFromOrder.new, to: [Pricing::PriceItemRemoved])
       event_store.subscribe(UpdateDiscount.new, to: [Pricing::PercentageDiscountSet, Pricing::PercentageDiscountChanged])
@@ -88,29 +79,35 @@ def call(event_store)
       event_store.subscribe(RegisterProduct.new, to: [ProductCatalog::ProductRegistered])
       event_store.subscribe(ChangeProductName.new, to: [ProductCatalog::ProductNamed])
       event_store.subscribe(ChangeProductPrice.new, to: [Pricing::PriceSet])
-      event_store.subscribe(CreateCustomer.new, to: [Crm::CustomerRegistered])
-      event_store.subscribe(AssignCustomerToOrder.new, to: [Crm::CustomerAssignedToOrder])
-      event_store.subscribe(SubmitOrder.new, to: [Fulfillment::OrderRegistered])
-      event_store.subscribe(ExpireOrder.new, to: [Pricing::OfferExpired])
-      event_store.subscribe(ConfirmOrder.new, to: [Fulfillment::OrderConfirmed])
-      event_store.subscribe(CancelOrder.new, to: [Fulfillment::OrderCancelled])
       event_store.subscribe(UpdateTimePromotionDiscountValue.new, to: [Pricing::PercentageDiscountSet])
       event_store.subscribe(RemoveTimePromotionDiscount.new, to: [Pricing::PercentageDiscountRemoved])
 
       event_store.subscribe(
-        ->(event) { broadcast_order_state_change(event.data.fetch(:order_id), 'Submitted') },
+        ->(event) {
+          broadcast_order_state_change(event.data.fetch(:order_id), 'Submitted')
+          event_store.link_event_to_stream(event, "Orders$all")
+        },
         to: [Fulfillment::OrderRegistered]
       )
       event_store.subscribe(
-        ->(event) { broadcast_order_state_change(event.data.fetch(:order_id), "Expired") },
+        ->(event) {
+          broadcast_order_state_change(event.data.fetch(:order_id), "Expired")
+          event_store.link_event_to_stream(event, "Orders$all")
+        },
         to: [Pricing::OfferExpired]
       )
       event_store.subscribe(
-        ->(event) { broadcast_order_state_change(event.data.fetch(:order_id), "Paid") },
+        ->(event) {
+          broadcast_order_state_change(event.data.fetch(:order_id), "Paid")
+          event_store.link_event_to_stream(event, "Orders$all")
+        },
         to: [Fulfillment::OrderConfirmed]
       )
       event_store.subscribe(
-        ->(event) { broadcast_order_state_change(event.data.fetch(:order_id), "Cancelled") },
+        ->(event) {
+          broadcast_order_state_change(event.data.fetch(:order_id), "Cancelled")
+          event_store.link_event_to_stream(event, "Orders$all")
+        },
         to: [Fulfillment::OrderCancelled]
       )
     end

apps/rails_application/app/read_models/orders/configuration.rb

@@ -2,8 +2,7 @@ module Orders
   class DraftOrder
     def call(event)
       Order.create(
-        uid: event.data.fetch(:order_id),
-        state: "Draft"
+        uid: event.data.fetch(:order_id)
       )
     end
   end