recover test coverage

Author: andrzejkrzywda

apps/rails_application/app/read_models/vat_rates/configuration.rb

@@ -11,7 +11,7 @@ class Configuration
     def call(event_store)
       event_store.subscribe(AddAvailableVatRate, to: [Taxes::AvailableVatRateAdded])
       event_store.subscribe(RemoveAvailableVatRate, to: [Taxes::AvailableVatRateRemoved])
-      event_store.subscribe(AssignStoreToAvailableVatRate.new, to: [Stores::VatRateRegistered])
+      event_store.subscribe(AssignStoreToAvailableVatRate, to: [Stores::VatRateRegistered])
     end
   end
 end

apps/rails_application/test/processes/promotions_calendar_test.rb

@@ -159,6 +159,29 @@ def test_start_time_is_inclusive
       assert_equal(40, discount.value)
     end
 
+    def test_ignores_other_event_types_in_promotion_stream
+      store_id = SecureRandom.uuid
+      time_promotion_id = SecureRandom.uuid
+
+      event_store.publish(
+        Pricing::PriceSet.new(data: { product_id: SecureRandom.uuid, price: 100 }),
+        stream_name: "Pricing::TimePromotion$#{time_promotion_id}"
+      )
+
+      event_store.publish(
+        Stores::TimePromotionRegistered.new(data: {
+          store_id: store_id,
+          time_promotion_id: time_promotion_id
+        }),
+        stream_name: "Stores::Store$#{store_id}"
+      )
+
+      calendar = PromotionsCalendar.new(event_store, store_id)
+      discount = calendar.current_time_promotions_discount
+
+      assert_instance_of(Pricing::Discounts::NoPercentageDiscount, discount)
+    end
+
     private
 
     def create_time_promotion(store_id, discount, start_time, end_time)

apps/rails_application/test/processes/shipment_process_test.rb

@@ -41,6 +41,23 @@ def test_need_address_to_authorize_shipment
       assert_no_command
     end
 
+    def test_submit_and_authorize_shipment_with_store_registration
+      given([offer_registered, order_placed, order_confirmed, shipping_address_added], process:)
+      assert_all_commands(
+        Stores::RegisterShipment.new(shipment_id: order_id, store_id: store_id),
+        Shipping::SubmitShipment.new(order_id:),
+        Shipping::AuthorizeShipment.new(order_id:),
+      )
+    end
+
+    def test_submit_shipment_with_store_registration_when_order_placed
+      given([offer_registered, order_placed, shipping_address_added], process:)
+      assert_all_commands(
+        Stores::RegisterShipment.new(shipment_id: order_id, store_id: store_id),
+        Shipping::SubmitShipment.new(order_id:),
+      )
+    end
+
     private
 
     def process
@@ -55,5 +72,18 @@ def shipping_address_added
         }
       )
     end
+
+    def offer_registered
+      Stores::OfferRegistered.new(
+        data: {
+          order_id: order_id,
+          store_id: store_id
+        }
+      )
+    end
+
+    def store_id
+      @store_id ||= SecureRandom.uuid
+    end
   end
 end

apps/rails_application/test/vat_rates/assign_store_to_available_vat_rate_test.rb

@@ -12,7 +12,10 @@ def test_assign_store_to_available_vat_rate
       event_store.publish(Taxes::AvailableVatRateAdded.new(data: { available_vat_rate_id: vat_rate_id, vat_rate: { code: "standard", rate: 20 } }))
       event_store.publish(Stores::VatRateRegistered.new(data: { store_id: store_id, vat_rate_id: vat_rate_id }))
 
-      assert_equal(store_id, AvailableVatRate.find_by!(uid: vat_rate_id).store_id)
+      vat_rates = VatRates.available_vat_rates_for_store(store_id)
+      assert_equal(1, vat_rates.count)
+      assert_equal(store_id, vat_rates.first.store_id)
+      assert_equal(vat_rate_id, vat_rates.first.uid)
     end
 
     def test_assign_store_to_existing_available_vat_rate
@@ -23,7 +26,9 @@ def test_assign_store_to_existing_available_vat_rate
 
       event_store.publish(Stores::VatRateRegistered.new(data: { store_id: store_id, vat_rate_id: vat_rate_id }))
 
-      assert_equal(store_id, AvailableVatRate.find_by!(uid: vat_rate_id).store_id)
+      vat_rates = VatRates.available_vat_rates_for_store(store_id)
+      assert_equal(1, vat_rates.count)
+      assert_equal(store_id, vat_rates.first.store_id)
     end
 
     def test_assigns_store_to_correct_vat_rate_by_uid
@@ -37,8 +42,9 @@ def test_assigns_store_to_correct_vat_rate_by_uid
 
       event_store.publish(Stores::VatRateRegistered.new(data: { store_id: store_id, vat_rate_id: vat_rate_1_id }))
 
-      assert_equal(store_id, AvailableVatRate.find_by!(uid: vat_rate_1_id).store_id)
-      assert_nil(AvailableVatRate.find_by!(uid: vat_rate_2_id).store_id)
+      vat_rates_for_store = VatRates.available_vat_rates_for_store(store_id)
+      assert_equal(1, vat_rates_for_store.count)
+      assert_equal(vat_rate_1_id, vat_rates_for_store.first.uid)
     end
   end
 end