fix tests

mostly by using Pricing or Fulfillment commands and eventst
instead of using Ordering ones

Author: porbas

ecommerce/pricing/test/apply_time_promotion_test.rb

@@ -1,4 +1,5 @@
 require_relative "test_helper"
+require "timecop"
 
 module Pricing
   class ApplyTimePromotionTest < Test
@@ -60,7 +61,9 @@ def item_added_to_basket_event(order_id, product_id)
       Pricing::PriceItemAdded.new(
         data: {
           product_id: product_id,
-          order_id: order_id
+          order_id: order_id,
+          price: 100,
+          catalog_price: 100
           }
         )
     end

rails_application/app/controllers/client/orders_controller.rb

@@ -15,7 +15,7 @@ def create
     rescue Orders::OrderHasUnavailableProducts => e
       unavailable_products = e.unavailable_products.join(", ")
       redirect_to edit_client_order_path(params[:order_id]), alert: "Order can not be submitted! #{unavailable_products} not available in requested quantity!"
-    rescue Ordering::Order::IsEmpty
+    rescue Pricing::CantAcceptEmptyOffer
       redirect_to edit_client_order_path(params[:order_id]), alert: "You can't submit an empty order"
     else
       redirect_to client_order_path(params[:order_id]), notice: "Your order is being submitted"

rails_application/app/controllers/orders_controller.rb

@@ -81,7 +81,7 @@ def create
   rescue Orders::OrderHasUnavailableProducts => e
     unavailable_products = e.unavailable_products.join(", ")
     redirect_to edit_order_path(params[:order_id]), alert: "Order can not be submitted! #{unavailable_products} not available in requested quantity!"
-  rescue Ordering::Order::IsEmpty
+  rescue Pricing::CantAcceptEmptyOffer
     redirect_to edit_order_path(params[:order_id]), alert: "You can't submit an empty order"
   rescue Crm::Customer::NotExists
     redirect_to order_path(params[:order_id]), alert: "Order can not be submitted! Customer does not exist."

rails_application/test/client_orders/order_cancelled_test.rb

@@ -19,7 +19,7 @@ def test_order_confirmed
       ))
 
       create_product(product_id, "Async Remote", 30)
-      run_command(Ordering::AddItemToBasket.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
       run_command(Ordering::SubmitOrder.new(order_id: order_id, order_number: order_number))
 
       event_store.publish(

rails_application/test/client_orders/order_paid_test.rb

@@ -13,7 +13,7 @@ def test_order_confirmed
 
       run_command(Crm::RegisterCustomer.new(customer_id: customer_id, name: "John Doe"))
       create_product(product_id, "Async Remote", 30)
-      run_command(Ordering::AddItemToBasket.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
 
       event_store.publish(
         Pricing::OrderTotalValueCalculated.new(

rails_application/test/client_orders/update_paid_orders_summary_test.rb

@@ -54,7 +54,7 @@ def set_price_to_product(product_id, price)
     end
 
     def add_item_to_basket(order_id, product_id)
-      run_command(Ordering::AddItemToBasket.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
     end
 
     def confirm_order(customer_id, order_id, total_amount)

rails_application/test/customers/update_paid_orders_summary_test.rb

@@ -26,7 +26,7 @@ def test_update_orders_summary
       add_item_to_basket(order_id, product_id)
       confirm_order(customer_id, order_id, 6)
 
-      customer = Customer.find(customer_id)
+      customer.reload
       assert_equal 9.to_d, customer.paid_orders_summary
     end
 
@@ -49,20 +49,11 @@ def set_price_to_product(product_id, price)
     end
 
     def add_item_to_basket(order_id, product_id)
-      run_command(Ordering::AddItemToBasket.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
     end
 
     def confirm_order(customer_id, order_id, total_amount)
       order_number = Ordering::FakeNumberGenerator::FAKE_NUMBER
-      event_store.publish(
-        Pricing::OrderTotalValueCalculated.new(
-          data: {
-            order_id: order_id,
-            discounted_amount: total_amount,
-            total_amount: total_amount
-          }
-        )
-      )
       run_command(
         Crm::AssignCustomerToOrder.new(customer_id: customer_id, order_id: order_id)
       )

rails_application/test/orders/order_cancelled_test.rb

@@ -8,7 +8,7 @@ def test_cancel_confirmed_order
       event_store = Rails.configuration.event_store
       customer_id = SecureRandom.uuid
       order_id = SecureRandom.uuid
-      order_number = Ordering::FakeNumberGenerator::FAKE_NUMBER
+      order_number = Fulfillment::FakeNumberGenerator::FAKE_NUMBER
       product_id = SecureRandom.uuid
 
       event_store.publish(Crm::CustomerRegistered.new(
@@ -19,8 +19,8 @@ def test_cancel_confirmed_order
       ))
 
       create_product(product_id, "Async Remote", 30)
-      run_command(Ordering::AddItemToBasket.new(order_id: order_id, product_id: product_id))
-      run_command(Ordering::SubmitOrder.new(order_id: order_id, order_number: order_number))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AcceptOffer.new(order_id: order_id))
 
       order_cancelled = Fulfillment::OrderCancelled.new(
         data: {

rails_application/test/orders/order_paid_test.rb

@@ -8,13 +8,13 @@ def test_order_confirmed
       event_store = Rails.configuration.event_store
       customer_id = SecureRandom.uuid
       order_id = SecureRandom.uuid
-      order_number = Ordering::FakeNumberGenerator::FAKE_NUMBER
+      order_number = Fulfillment::FakeNumberGenerator::FAKE_NUMBER
       product_id = SecureRandom.uuid
 
       create_product(product_id, "Async Remote", 10)
       run_command(Crm::RegisterCustomer.new(customer_id: customer_id, name: "John Doe"))
-      run_command(Ordering::AddItemToBasket.new(order_id: order_id, product_id: product_id))
-      run_command(Ordering::SubmitOrder.new(order_id: order_id, order_number: order_number))
+      run_command(Pricing::AddPriceItem.new(order_id: order_id, product_id: product_id))
+      run_command(Pricing::AcceptOffer.new(order_id: order_id))
       run_command(
         Crm::AssignCustomerToOrder.new(customer_id: customer_id, order_id: order_id)
       )

rails_application/test/orders/order_placed_test.rb

@@ -22,7 +22,7 @@ def test_create_when_not_exists
       )
       run_command(Pricing::SetPrice.new(product_id: product_id, price: 20))
       order_id = SecureRandom.uuid
-      order_number = Ordering::FakeNumberGenerator::FAKE_NUMBER
+      order_number = Fulfillment::FakeNumberGenerator::FAKE_NUMBER
 
       event_store.publish(
         Pricing::PriceItemAdded.new(
@@ -34,11 +34,10 @@ def test_create_when_not_exists
           }
         )
       )
-      order_placed = Ordering::OrderPlaced.new(
+      order_placed = Fulfillment::OrderRegistered.new(
         data: {
           order_id: order_id,
           order_number: order_number,
-          order_lines: { product_id => 1 }
         }
       )
       event_store.publish(order_placed)