Removed PriceItemValueCalculated and CalculateSubAmounts

Author: andrzejkrzywda

ecommerce/pricing/lib/pricing.rb

@@ -8,7 +8,6 @@
 require_relative "pricing/price_change"
 require_relative "pricing/time_promotion"
 require_relative "pricing/promotions_calendar"
-require_relative "pricing/calculate_order_sub_amounts_value"
 require_relative "pricing/apply_time_promotion"
 
 module Pricing
@@ -49,10 +48,6 @@ def call(event_store, command_bus)
         SetFuturePrice,
         SetFuturePriceHandler.new(event_store)
       )
-      command_bus.register(
-        CalculateSubAmounts,
-        OnCalculateSubAmounts.new(event_store).public_method(:calculate_sub_amounts)
-      )
       command_bus.register(
         SetPercentageDiscount,
         SetPercentageDiscountHandler.new(event_store)
@@ -114,15 +109,6 @@ def call(event_store, command_bus)
         ProductMadeFreeForOrder,
         FreeProductRemovedFromOrder
       ])
-      event_store.subscribe(CalculateOrderTotalSubAmountsValue, to: [
-        PriceItemAdded,
-        PriceItemRemoved,
-        PercentageDiscountSet,
-        PercentageDiscountRemoved,
-        PercentageDiscountChanged,
-        ProductMadeFreeForOrder,
-        FreeProductRemovedFromOrder
-      ])
     end
   end
 end

ecommerce/pricing/lib/pricing/calculate_order_sub_amounts_value.rb

@@ -14,10 +14,6 @@ class RemovePriceItem < Infra::Command
     alias aggregate_id order_id
   end
 
-  class CalculateSubAmounts < Infra::Command
-    attribute :order_id, Infra::Types::UUID
-    alias aggregate_id order_id
-  end
 
   class SetPrice < Infra::Command
     attribute :product_id, Infra::Types::UUID

ecommerce/pricing/lib/pricing/commands.rb

@@ -19,13 +19,6 @@ class TimePromotionCreated < Infra::Event
   end
 
 
-  class PriceItemValueCalculated < Infra::Event
-    attribute :order_id, Infra::Types::UUID
-    attribute :product_id, Infra::Types::UUID
-    attribute :quantity, Infra::Types::Quantity
-    attribute :discounted_amount, Infra::Types::Value
-    attribute :amount, Infra::Types::Value
-  end
 
   class PercentageDiscountSet < Infra::Event
     attribute :order_id, Infra::Types::UUID

ecommerce/pricing/lib/pricing/events.rb

@@ -88,25 +88,6 @@ def remove_free_product(order_id, product_id)
       )
     end
 
-
-    def calculate_sub_amounts
-      sub_amounts_total = @list.sub_amounts_total
-
-      sub_amounts_total.each_pair do |product_id, h|
-        apply(
-          PriceItemValueCalculated.new(
-            data: {
-              order_id: @id,
-              product_id: product_id,
-              quantity: h.fetch(:quantity),
-              amount: h.fetch(:base_amount),
-              discounted_amount: h.fetch(:amount),
-            }
-          )
-        )
-      end
-    end
-
     def use_coupon(coupon_id, discount)
       apply CouponUsed.new(
         data: {
@@ -152,8 +133,6 @@ def expire
       @list.remove_item(event.data.fetch(:product_id), event.data.fetch(:price))
     end
 
-    on PriceItemValueCalculated do |event|
-    end
 
 
     on PercentageDiscountSet do |event|

ecommerce/pricing/lib/pricing/offer.rb

@@ -137,21 +137,6 @@ def call(command)
     end
   end
 
-  class OnCalculateSubAmounts
-    include Infra::Retry
-
-    def initialize(event_store)
-      @repository = Infra::AggregateRootRepository.new(event_store)
-    end
-
-    def calculate_sub_amounts(command)
-      with_retry do
-        @repository.with_aggregate(Offer, command.aggregate_id) do |order|
-          order.calculate_sub_amounts
-        end
-      end
-    end
-  end
 
   class OnCouponRegister
     def initialize(event_store)

ecommerce/pricing/lib/pricing/services.rb

@@ -13,65 +13,6 @@ def test_configuration
     end
 
 
-    def test_calculates_sub_amounts
-      product_1_id = SecureRandom.uuid
-      product_2_id = SecureRandom.uuid
-      set_price(product_1_id, 20)
-      set_price(product_2_id, 30)
-      order_id = SecureRandom.uuid
-      stream = stream_name(order_id)
-
-      assert_events(stream) { calculate_sub_amounts(order_id) }
-
-      add_item(order_id, product_1_id)
-      add_item(order_id, product_2_id)
-      add_item(order_id, product_2_id)
-      assert_events(
-        stream,
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_1_id,
-            quantity: 1,
-            amount: 20,
-            discounted_amount: 20
-          }
-        ),
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_2_id,
-            quantity: 2,
-            amount: 60,
-            discounted_amount: 60
-          }
-        )
-      ) { calculate_sub_amounts(order_id) }
-      run_command(
-        Pricing::SetPercentageDiscount.new(order_id: order_id, amount: 10)
-      )
-      assert_events(
-        stream,
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_1_id,
-            quantity: 1,
-            amount: 20,
-            discounted_amount: 18
-          }
-        ),
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_2_id,
-            quantity: 2,
-            amount: 60,
-            discounted_amount: 54
-          }
-        )
-      ) { calculate_sub_amounts(order_id) }
-    end
 
     def test_sets_time_promotion_discount
       order_id = SecureRandom.uuid
@@ -369,9 +310,6 @@ def stream_name(order_id)
       "Pricing::Offer$#{order_id}"
     end
 
-    def calculate_sub_amounts(order_id)
-      run_command(CalculateSubAmounts.new(order_id: order_id))
-    end
 
     def create_active_time_promotion(discount)
       run_command(

ecommerce/pricing/test/pricing_test.rb

@@ -18,15 +18,6 @@ def test_adding
             base_price: 20,
             price: 20
           }
-        ),
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_id,
-            quantity: 1,
-            amount: 20,
-            discounted_amount: 20,
-          }
         )
       ) { add_item(order_id, product_id) }
 
@@ -39,15 +30,6 @@ def test_adding
             base_price: 20,
             price: 20
           }
-        ),
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_id,
-            quantity: 2,
-            amount: 40,
-            discounted_amount: 40,
-          }
         )
       ) { add_item(order_id, product_id) }
 
@@ -70,15 +52,6 @@ def test_removing
             base_price: 20,
             price: 20
           }
-        ),
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_id,
-            quantity: 1,
-            amount: 20,
-            discounted_amount: 20,
-          }
         )
       ) { remove_item(order_id, product_id) }
 

ecommerce/pricing/test/simple_offer_test.rb

@@ -65,53 +65,6 @@ def test_calculates_total_value_with_time_promotion
       ) { add_item(order_id, product_1_id) }
     end
 
-    def test_calculates_sub_amounts_with_combined_discounts
-      product_1_id = SecureRandom.uuid
-      product_2_id = SecureRandom.uuid
-      set_price(product_1_id, 20)
-      set_price(product_2_id, 30)
-      order_id = SecureRandom.uuid
-      stream = stream_name(order_id)
-      data = {
-        time_promotion_id: SecureRandom.uuid,
-        discount: 50,
-        start_time: Time.current - 1,
-        end_time: Time.current + 100,
-        label: "Last Minute"
-      }
-
-      run_command(CreateTimePromotion.new(data))
-
-      add_item(order_id, product_1_id)
-      add_item(order_id, product_2_id)
-      add_item(order_id, product_2_id)
-
-      run_command(
-        Pricing::SetPercentageDiscount.new(order_id: order_id, amount: 10)
-      )
-
-      assert_events_contain(
-        stream,
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_1_id,
-            quantity: 1,
-            amount: 20,
-            discounted_amount: 8
-          }
-        ),
-        PriceItemValueCalculated.new(
-          data: {
-            order_id: order_id,
-            product_id: product_2_id,
-            quantity: 2,
-            amount: 60,
-            discounted_amount: 24
-          }
-        )
-      ) { calculate_sub_amounts(order_id) }
-    end
 
     def test_cant_create_twice
       uid = SecureRandom.uuid
@@ -164,8 +117,5 @@ def set_time_promotion_range(time_promotion_id, start_time, end_time, discount)
       )
     end
 
-    def calculate_sub_amounts(order_id)
-      run_command(CalculateSubAmounts.new(order_id: order_id))
-    end
   end
 end