Fix env issues.

Author: dysk

.github/workflows/pricing.yml

@@ -73,6 +73,10 @@ jobs:
             fi
           fi
 
+          echo "Debug before GITHUB_OUTPUT: FINAL_MUTANT_MODE='${FINAL_MUTANT_MODE}'"
+          echo "Debug before GITHUB_OUTPUT: FINAL_SINCE_TARGET='${FINAL_SINCE_TARGET}'"
+          echo "Debug before GITHUB_OUTPUT: FINAL_NUM_GROUPS='${FINAL_NUM_GROUPS}'"
+
           echo "mutant_mode=${FINAL_MUTANT_MODE}" >> $GITHUB_OUTPUT
           echo "mutant_since_target=${FINAL_SINCE_TARGET}" >> $GITHUB_OUTPUT
           echo "num_groups=${FINAL_NUM_GROUPS}" >> $GITHUB_OUTPUT
@@ -201,7 +205,15 @@ jobs:
           bundler-cache: true
           working-directory: ${{ env.WORKING_DIRECTORY }}
       - name: Run mutation tests (parallel group for pricing)
-        run: make mutate
+        run: |
+          echo "Debug from CI step before calling make (using PASSED_ var names):"
+          echo "  Value for PASSED_MODE='${{ env.ENV_CLI_MUTANT_MODE }}'"
+          echo "  Value for PASSED_SINCE_TARGET='${{ env.ENV_CLI_MUTANT_SINCE_TARGET }}'"
+          echo "  CI_MUTATE_SUBJECTS (from env): '${{ env.CI_MUTATE_SUBJECTS }}'"
+        
+          make mutate \
+            PASSED_MODE="${{ env.ENV_CLI_MUTANT_MODE }}" \
+            PASSED_SINCE_TARGET="${{ env.ENV_CLI_MUTANT_SINCE_TARGET }}"
         working-directory: ${{ env.WORKING_DIRECTORY }}
         env:
           CI_MUTATE_SUBJECTS: ${{ matrix.subject_group }}

ecommerce/pricing/Makefile

@@ -1,3 +1,6 @@
+MUTANT_MODE_INTERNAL := $(PASSED_MODE)
+MUTANT_SINCE_TARGET_INTERNAL := $(PASSED_SINCE_TARGET)
+
 install:
 	@bundle install
 
@@ -6,28 +9,45 @@ test:
 	@bundle exec ruby -e "require \"rake/rake_test_loader\"" test/*_test.rb
 
 mutate:
-	$(eval ACTUAL_MUTANT_ARGS :=)
+	@echo "--- Makefile Debug: Initial State ---"
+	@echo "PASSED_MODE (from CLI):                  '$(PASSED_MODE)'"
+	@echo "PASSED_SINCE_TARGET (from CLI):          '$(PASSED_SINCE_TARGET)'"
+	@echo "CI_MUTATE_SUBJECTS (from environment):   '$(CI_MUTATE_SUBJECTS)'"
+
+	@echo "--- Makefile Debug: After Internal Assignment ---"
+	@echo "MUTANT_MODE_INTERNAL (after assign):     '$(MUTANT_MODE_INTERNAL)'"
+	@echo "MUTANT_SINCE_TARGET_INTERNAL (after assign):'$(MUTANT_SINCE_TARGET_INTERNAL)'"
+
 	$(eval SUBJECTS_TO_RUN := $(strip $(CI_MUTATE_SUBJECTS)))
+	$(eval TEMP_ACTUAL_MUTANT_ARGS :=)
 
 	@echo "--- Preparing Mutation Test Run for pricing ---"
-ifeq ($(MUTANT_MODE),incremental)
-	ifndef MUTANT_SINCE_TARGET
-		$(error MUTANT_MODE is 'incremental', but MUTANT_SINCE_TARGET is not set. This variable should be set by the CI workflow.)
+ifeq ($(MUTANT_MODE_INTERNAL),incremental)
+	@echo "  Conditional: MUTANT_MODE_INTERNAL is 'incremental'."
+	ifndef MUTANT_SINCE_TARGET_INTERNAL
+		$(error FATAL ERROR (Makefile): MUTANT_MODE_INTERNAL ('$(MUTANT_MODE_INTERNAL)') is incremental, but MUTANT_SINCE_TARGET_INTERNAL is NOT DEFINED. PASSED_SINCE_TARGET was '$(PASSED_SINCE_TARGET)'.)
 	endif
-	$(eval ACTUAL_MUTANT_ARGS := --since $(MUTANT_SINCE_TARGET))
-	@echo "Mutation Mode: Incremental"
-	@echo "Target for --since: $(MUTANT_SINCE_TARGET)"
+	ifeq ($(strip $(MUTANT_SINCE_TARGET_INTERNAL)),)
+		$(error FATAL ERROR (Makefile): MUTANT_MODE_INTERNAL ('$(MUTANT_MODE_INTERNAL)') is incremental, but MUTANT_SINCE_TARGET_INTERNAL IS EMPTY. PASSED_SINCE_TARGET was '$(PASSED_SINCE_TARGET)', internal value was '[$(MUTANT_SINCE_TARGET_INTERNAL)]'.)
+	endif
+
+	@echo "  MUTANT_SINCE_TARGET_INTERNAL appears to be set and non-empty: '[$(MUTANT_SINCE_TARGET_INTERNAL)]'"
+	$(eval TEMP_ACTUAL_MUTANT_ARGS := --since $(MUTANT_SINCE_TARGET_INTERNAL))
+	@echo "  Action: Set for Incremental Mutation."
+	@echo "  Target for --since: '$(MUTANT_SINCE_TARGET_INTERNAL)'"
 else
-	@echo "Mutation Mode: Full"
+	@echo "  Conditional: MUTANT_MODE_INTERNAL is NOT 'incremental' (actual value: '$(MUTANT_MODE_INTERNAL)'). Setting for Full Mutation."
 endif
 
+	@echo "  Final TEMP_ACTUAL_MUTANT_ARGS: '$(TEMP_ACTUAL_MUTANT_ARGS)'"
 ifeq ($(SUBJECTS_TO_RUN),)
-	@echo "Subjects: All relevant (within scope of full/incremental mode)"
+	@echo "  Subjects: All relevant (within scope of full/incremental mode)"
 else
-	@echo "Subjects: Specific group for CI - '$(SUBJECTS_TO_RUN)'"
+	@echo "  Subjects: Specific group for CI - '$(SUBJECTS_TO_RUN)'" 
 endif
-	@echo "------------------------------------"
-	@echo "Executing: bundle exec mutant run $(ACTUAL_MUTANT_ARGS) $(SUBJECTS_TO_RUN)"
-	@bundle exec mutant run $(ACTUAL_MUTANT_ARGS) $(SUBJECTS_TO_RUN)
+	@echo "-----------------------------------------------------"
+
+	@echo "Executing: bundle exec mutant run $(TEMP_ACTUAL_MUTANT_ARGS) $(SUBJECTS_TO_RUN)"
+	@bundle exec mutant run $(TEMP_ACTUAL_MUTANT_ARGS) $(SUBJECTS_TO_RUN)
 
 .PHONY: install test mutate