same behavior of adapters when reading from or to non-existent event

Previously, if we specified starting or ending id of non-existing event
and try to read events:

* with InMemoryRepository we got:
NoMethodError: undefined method '+' for nil:NilClass

* with ActiveRecord adapter we got: ActiveRecord::RecordNotFound

We need these adapters to act in the same manner.
My suggestion is to throw EventNotFoundInStream or EventNotFound
depending on if the stream was specified.

Author: pjurewicz

ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb

@@ -139,6 +139,8 @@ def start_condition(specification)
           @stream_klass.find_by!(event_id: specification.start, stream: specification.stream.name),
           @stream_klass.table_name
         )
+      rescue ::ActiveRecord::RecordNotFound
+        raise RubyEventStore::EventNotFoundInStream.new(specification.start)
       end
 
       def stop_condition(specification)
@@ -147,6 +149,8 @@ def stop_condition(specification)
           @stream_klass.find_by!(event_id: specification.stop, stream: specification.stream.name),
           @stream_klass.table_name
         )
+      rescue ::ActiveRecord::RecordNotFound
+        raise RubyEventStore::EventNotFoundInStream.new(specification.stop)
       end
 
       def start_condition_in_global_stream(specification)
@@ -155,6 +159,8 @@ def start_condition_in_global_stream(specification)
           @event_klass.find_by!(event_id: specification.start),
           @event_klass.table_name
         )
+      rescue ::ActiveRecord::RecordNotFound
+        raise RubyEventStore::EventNotFound.new(specification.start)
       end
 
       def stop_condition_in_global_stream(specification)
@@ -163,6 +169,8 @@ def stop_condition_in_global_stream(specification)
           @event_klass.find_by!(event_id: specification.stop),
           @event_klass.table_name
         )
+      rescue ::ActiveRecord::RecordNotFound
+        raise RubyEventStore::EventNotFound.new(specification.stop)
       end
 
       def coalesce(*exprs)

ruby_event_store/lib/ruby_event_store/in_memory_repository.rb

@@ -150,8 +150,12 @@ def read_scope(spec)
       serialized_records = serialized_records.select { |e| spec.with_types.any? { |x| x.eql?(e.event_type) } } if spec
         .with_types?
       serialized_records = serialized_records.reverse if spec.backward?
-      serialized_records = serialized_records.drop(index_of(serialized_records, spec.start) + 1) if spec.start
-      serialized_records = serialized_records.take(index_of(serialized_records, spec.stop)) if spec.stop
+      begin
+        serialized_records = serialized_records.drop(index_of(serialized_records, spec.start) + 1) if spec.start
+        serialized_records = serialized_records.take(index_of(serialized_records, spec.stop)) if spec.stop
+      rescue EventNotFound => e
+        raise spec.stream.global? ? e : EventNotFoundInStream
+      end
       serialized_records = serialized_records.take(spec.limit) if spec.limit?
       serialized_records = serialized_records.select { |sr| Time.iso8601(time_comparison_field(spec, sr)) < spec.older_than } if spec
         .older_than
@@ -220,7 +224,10 @@ def has_event_in_stream?(event_id, stream_name)
     end
 
     def index_of(source, event_id)
-      source.index { |item| item.event_id.eql?(event_id) }
+      index = source.index { |item| item.event_id.eql?(event_id) }
+      raise EventNotFound.new(event_id) unless index
+
+      index
     end
 
     def compute_position(resolved_version, index)

ruby_event_store/lib/ruby_event_store/spec/event_repository_lint.rb

@@ -1055,6 +1055,36 @@ def read_events_backward(repository, stream = nil, from: nil, to: nil, count: ni
       expect(repository.read(specification.to(events[4].event_id).backward.read_last.result)).to be_nil
     end
 
+    specify do
+      event = SRecord.new
+      repository.append_to_stream([event], Stream.new('dummy'), ExpectedVersion.any)
+      expect do
+        repository.read(specification.stream('another').from(event.event_id).result).to_a
+      end.to raise_error(RubyEventStore::EventNotFoundInStream)
+    end
+
+    specify do
+      event = SRecord.new
+      repository.append_to_stream([event], Stream.new('dummy'), ExpectedVersion.any)
+      expect do
+        repository.read(specification.stream('another').to(event.event_id).result).to_a
+      end.to raise_error(RubyEventStore::EventNotFoundInStream)
+    end
+
+    specify do
+      not_existing_uuid = SecureRandom.uuid
+      expect do
+        repository.read(specification.from(not_existing_uuid).result).to_a
+      end.to raise_error(RubyEventStore::EventNotFound)
+    end
+
+    specify do
+      not_existing_uuid = SecureRandom.uuid
+      expect do
+        repository.read(specification.to(not_existing_uuid).result).to_a
+      end.to raise_error(RubyEventStore::EventNotFound)
+    end
+
     context "#update_messages" do
       specify "changes events" do
         skip unless helper.supports_upsert?